Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare admin domain from the start, not as a substring #38791

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

zapotocnylubos
Copy link

Description (*)

When custom admin URL is used, the current algorithm wrongly detects custom admin URL, when its in a form of subdomain (for example admin.domain.com)

Related Pull Requests

None

Fixed Issues (if relevant)

  1. Fixes Magento admin URL routing wrong detection and CORS errors #37663

Manual testing scenarios (*)

Install Magento and make sure it is working URL should be m2.domain.local

  1. Enable and set the admin path to "/admin123" (in env.php), and make sure admin UI logs in after changing the admin path
  2. Create a frontend (store_view) on the domain "m2.domain.local"
  3. Set the custom admin URL to "admin.m2.domain.local". Also, make sure u r updating the virtual host and host files accordingly. Restart the httpd server
  4. Access using a custom URL, ur application should work

Questions or comments

None

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Jun 4, 2024

Hi @zapotocnylubos. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 4, 2024
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Jun 4, 2024
@zapotocnylubos zapotocnylubos reopened this Jun 4, 2024
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard Jun 4, 2024
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Jun 4, 2024
@zapotocnylubos
Copy link
Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
Pull Requests Dashboard
  
Pending Review
Development

Successfully merging this pull request may close these issues.

Magento admin URL routing wrong detection and CORS errors
1 participant