-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid a misconfiguration infinite loop #38794
base: 2.4-develop
Are you sure you want to change the base?
Conversation
The virtual type configurations are not supposed to be self‑referential, … but if they ever are this function will spin in an infinite loop.
Hi @ergohack. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@magento create issue |
Description (*)
The virtual type configurations, in
di.xml
files, are not supposed to be self‑referential, … but if they ever are this function will spin in an infinite loop.Changes
Added a test to avoid a self‑referential mapping, returning the self‑reference instead of endlessly spinning.
Fixed Issues (if relevant)
unknown
Manual testing scenarios (*)
Configure a
di.xml
<virtualType …>
node to be self‑referential (i.e. not actually virtual). This will cause the app to spin, infinitely, on the dereferencing attempt. Note that the self‑reference can be from a chain of<virtualType …>
nodes and not just a single node.Contribution checklist (*)
Resolved issues: