Allow custom catalog rule conditions

[ilnytskyi]

Description (*)

Due to the check based on object attribute there is no way to use custom implementations for catalog rule validation

$condition->getType() === SimpleCondition::class

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Create custom catalog rule with custom object
2. Use custom validation logic

Expected Result:

1. Magento should create and allow custom classes in catalog rules
   Current Result:
2. Magento creates only SimpleCondition object so custom implementation is not possible

Questions or comments

In SalesRule module there is a way to use custom classes and objects but not in catalog rules module.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Allow custom catalog rule conditions #39339: Allow custom catalog rule conditions

[m2-assistant]

Hi @ilnytskyi. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[ilnytskyi]

@magento run all tests

[engcom-Hotel]

@magento create issue