Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix %name, translation #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

eerorika
Copy link

@eerorika eerorika commented Feb 1, 2019

%name is the name of a variable. It is probably a bug in magento to use a translate block for it in the first place, but the name of the variable must not be changed in a translation string. In the current version of mageplaza/magento-2-finnish-language-pack/fi_FI.csv this is translated as "%name,","%nimi,",module,Magento_GiftCard, which breaks email templates that use {{trans "%name," ...

%name is the name of a variable. It is probably a bug in magento to use a translate block for it anyway, but the name of the variable must not be changed in a translation string. In the current version of mageplaza/magento-2-finnish-language-pack/fi_FI.csv this is translated as `"%name,","%name,",module,Magento_GiftCard`, which breaks email templates that use `{{trans "%name," ...`
@pomppa
Copy link

pomppa commented May 9, 2020

👍

This is still valid. What I would do, however, is remove all of those lines as there really is no need to translate this variable. But if we need to translate it for some reason (as the github_contribution.csv does not really offer a way to delete lines) you should add all following lines there:

 "%name,","%name,",module,Magento_Company
 "%name,","%name,",module,Magento_Customer
 "%name,","%name,",module,Magento_CustomerBalance
 "%name,","%name,",module,Magento_GiftCard
 "%name,","%name,",module,Magento_GiftCardAccount
 "%name,","%name,",module,Magento_GiftRegistry
 "%name,","%name,",module,Magento_ProductAlert
 "%name,","%name,",module,Magento_Reminder
 "%name,","%name,",module,Magento_Reward
 "%name,","%name,",module,Magento_Rma
 "%name,","%name,",module,Magento_Sales
 "%name,","%name,",module,Magento_SendFriend
 "%name,","%name,",module,Magento_Theme
 "%name,","%name,",module,Magento_User
 "%name,","%name,",theme,frontend\Magento\luma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants