Adding analytics API service #16
Conversation
| return { | ||
| 'badges_sold': c.BADGES_SOLD, | ||
| 'remaining_badges': c.REMAINING_BADGES, | ||
| 'badges_price': c.BADGE_PRICE, |
There was a problem hiding this comment.
Are you sure you want this to be badges_price and not badge_price?
There was a problem hiding this comment.
This code snippet was taken from uber/uber/site_sections/registration.py to bring it into a proper service, I'm not sure if badges_price is actually correct - I believe @binary1230 added this code initially.
There was a problem hiding this comment.
I still vote for "badge_price"
There was a problem hiding this comment.
I think we only ever used badges_price on the magstock site. if this is a copy of what's in registration.py then you can name stuff here whatever you want.
There was a problem hiding this comment.
Two things:
- I agree with Eli's comment
- Failing pep8:
pep8 runtests: commands[0] | pep8 uber_analytics/
uber_analytics/api.py:5:1: E302 expected 2 blank lines, found 1
uber_analytics/api.py:24:33: E231 missing whitespace after ','
uber_analytics/api.py:24:46: W292 no newline at end of file
Also, this could probably use some unit tests, but since you're probably the only one using it, I'm not going to enforce that.
This change isn't the ideal way to solve this problem. Ideally we'd be defining the services as the foundation of the uber_analytics plugin and building the graph and frontend around those services.
This way of doing things does as little as possible to change existing code to make it easier to backport this change to older instances of uber to be able to pull historical stats.