Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting to get new sqlalchemy working #4346

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions alembic/env.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from alembic import context

import uber
from residue import CoerceUTF8, UTCDateTime, UUID
from uber.migration import version_locations_option
from uber.models import Choice, MultiChoice, Session

Expand All @@ -33,24 +32,6 @@ def include_object(object, name, type_, reflected, compare_to):
return not name.startswith('alembic_version')


def render_item(type_, obj, autogen_context):
"""Apply custom rendering for selected items."""
if type_ == 'type':
if isinstance(obj, Choice):
return 'sa.Integer()'
elif isinstance(obj, UTCDateTime):
autogen_context.imports.add('import residue')
return 'residue.UTCDateTime()'
elif isinstance(obj, (CoerceUTF8, MultiChoice)):
return 'sa.Unicode()'
elif isinstance(obj, UUID):
autogen_context.imports.add('import residue')
return 'residue.UUID()'

# Default rendering for other objects
return False


def process_revision_directives(context, revision, directives):
"""If an empty migration is autogenerated, don't create a script."""
if alembic_config.cmd_opts.autogenerate:
Expand All @@ -74,7 +55,6 @@ def run_migrations_offline():
include_object=include_object,
url=uber.config.c.SQLALCHEMY_URL,
target_metadata=target_metadata,
render_item=render_item,
literal_binds=True,
process_revision_directives=process_revision_directives)

Expand All @@ -96,7 +76,6 @@ def run_migrations_online():
include_object=include_object,
connection=connection,
target_metadata=target_metadata,
render_item=render_item,
process_revision_directives=process_revision_directives)

with context.begin_transaction():
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
from sqlalchemy.dialects import postgresql
from sqlalchemy.schema import ForeignKey
from sqlalchemy.sql import table
from sqlalchemy.types import String
import residue
from sqlalchemy.types import String, UUID


try:
Expand Down Expand Up @@ -57,20 +56,20 @@ def sqlite_column_reflect_listener(inspector, table, column_info):

approved_email_table = table(
'approved_email',
sa.Column('id', residue.UUID()),
sa.Column('id', UUID()),
sa.Column('ident', sa.Unicode()),
)

email_table = table(
'email',
sa.Column('id', residue.UUID()),
sa.Column('id', UUID()),
sa.Column('ident', sa.Unicode()),
sa.Column('automated_email_id', residue.UUID(), ForeignKey('automated_email.id')),
sa.Column('automated_email_id', UUID(), ForeignKey('automated_email.id')),
)

automated_email_table = table(
'automated_email',
sa.Column('id', residue.UUID()),
sa.Column('id', UUID()),
sa.Column('ident', sa.Unicode()),
sa.Column('approved', sa.Boolean()),
)
Expand Down Expand Up @@ -114,8 +113,8 @@ def upgrade():
batch_op.add_column(sa.Column('unapproved_count', sa.Integer(), server_default='0', nullable=False))
batch_op.add_column(sa.Column('allow_post_con', sa.Boolean(), server_default='False', nullable=False))
batch_op.add_column(sa.Column('allow_at_the_con', sa.Boolean(), server_default='False', nullable=False))
batch_op.add_column(sa.Column('active_after', residue.UTCDateTime(), nullable=True))
batch_op.add_column(sa.Column('active_before', residue.UTCDateTime(), nullable=True))
batch_op.add_column(sa.Column('active_after', DateTime(), nullable=True))
batch_op.add_column(sa.Column('active_before', DateTime(), nullable=True))
if 'pk_approved_email' in existing_primarykeys:
batch_op.drop_constraint('pk_approved_email', type_='primary')
if 'approved_email_pkey' in existing_primarykeys:
Expand All @@ -138,8 +137,8 @@ def upgrade():
op.add_column('automated_email', sa.Column('unapproved_count', sa.Integer(), server_default='0', nullable=False))
op.add_column('automated_email', sa.Column('allow_post_con', sa.Boolean(), server_default='False', nullable=False))
op.add_column('automated_email', sa.Column('allow_at_the_con', sa.Boolean(), server_default='False', nullable=False))
op.add_column('automated_email', sa.Column('active_after', residue.UTCDateTime(), nullable=True))
op.add_column('automated_email', sa.Column('active_before', residue.UTCDateTime(), nullable=True))
op.add_column('automated_email', sa.Column('active_after', DateTime(), nullable=True))
op.add_column('automated_email', sa.Column('active_before', DateTime(), nullable=True))
if 'pk_approved_email' in existing_primarykeys:
op.drop_constraint('pk_approved_email', 'automated_email', type_='primary')
if 'approved_email_pkey' in existing_primarykeys:
Expand All @@ -154,14 +153,14 @@ def upgrade():
batch_op.alter_column('dest', new_column_name='to')
batch_op.add_column(sa.Column('bcc', sa.Unicode(), server_default='', nullable=False))
batch_op.add_column(sa.Column('cc', sa.Unicode(), server_default='', nullable=False))
batch_op.add_column(sa.Column('automated_email_id', residue.UUID(), nullable=True))
batch_op.add_column(sa.Column('automated_email_id', UUID(), nullable=True))
batch_op.add_column(sa.Column('sender', sa.Unicode(), server_default='', nullable=False))
batch_op.create_foreign_key(op.f('fk_email_automated_email_id_automated_email'), 'automated_email', ['automated_email_id'], ['id'], ondelete='set null')
else:
op.alter_column('email', 'dest', new_column_name='to')
op.add_column('email', sa.Column('bcc', sa.Unicode(), server_default='', nullable=False))
op.add_column('email', sa.Column('cc', sa.Unicode(), server_default='', nullable=False))
op.add_column('email', sa.Column('automated_email_id', residue.UUID(), nullable=True))
op.add_column('email', sa.Column('automated_email_id', UUID(), nullable=True))
op.add_column('email', sa.Column('sender', sa.Unicode(), server_default='', nullable=False))
op.create_foreign_key(op.f('fk_email_automated_email_id_automated_email'), 'email', 'automated_email', ['automated_email_id'], ['id'], ondelete='set null')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
depends_on = None

from alembic import op
import residue
import sqlalchemy as sa
from sqlalchemy import func
from sqlalchemy.sql import and_, table, select
from sqlalchemy.types import UUID



Expand Down Expand Up @@ -55,7 +55,7 @@ def sqlite_column_reflect_listener(inspector, table, column_info):

attendee_table = table(
'attendee',
sa.Column('id', residue.UUID()),
sa.Column('id', UUID()),
sa.Column('hotel_pin', sa.Unicode()),
)

Expand Down
16 changes: 8 additions & 8 deletions alembic/versions/181ceea98b62_add_art_show_sales_tables.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

from alembic import op
import sqlalchemy as sa
import residue
from sqlalchemy.types import UUID


try:
Expand Down Expand Up @@ -53,23 +53,23 @@ def sqlite_column_reflect_listener(inspector, table, column_info):

def upgrade():
op.create_table('art_show_receipt',
sa.Column('id', residue.UUID(), nullable=False),
sa.Column('id', UUID(), nullable=False),
sa.Column('invoice_num', sa.Integer(), server_default='0', nullable=False),
sa.Column('attendee_id', residue.UUID(), nullable=True),
sa.Column('closed', residue.UTCDateTime(), nullable=True),
sa.Column('attendee_id', UUID(), nullable=True),
sa.Column('closed', DateTime(), nullable=True),
sa.ForeignKeyConstraint(['attendee_id'], ['attendee.id'], name=op.f('fk_art_show_receipt_attendee_id_attendee'), ondelete='SET NULL'),
sa.PrimaryKeyConstraint('id', name=op.f('pk_art_show_receipt'))
)
op.create_table('art_show_payment',
sa.Column('id', residue.UUID(), nullable=False),
sa.Column('receipt_id', residue.UUID(), nullable=True),
sa.Column('id', UUID(), nullable=False),
sa.Column('receipt_id', UUID(), nullable=True),
sa.Column('amount', sa.Integer(), server_default='0', nullable=False),
sa.Column('type', sa.Integer(), server_default='180350097', nullable=False),
sa.Column('when', residue.UTCDateTime(), nullable=False),
sa.Column('when', DateTime(), nullable=False),
sa.ForeignKeyConstraint(['receipt_id'], ['art_show_receipt.id'], name=op.f('fk_art_show_payment_receipt_id_art_show_receipt'), ondelete='SET NULL'),
sa.PrimaryKeyConstraint('id', name=op.f('pk_art_show_payment'))
)
op.add_column('art_show_piece', sa.Column('receipt_id', residue.UUID(), nullable=True))
op.add_column('art_show_piece', sa.Column('receipt_id', UUID(), nullable=True))
op.add_column('art_show_piece', sa.Column('winning_bid', sa.Integer(), server_default='0', nullable=True))
op.create_foreign_key(op.f('fk_art_show_piece_receipt_id_art_show_receipt'), 'art_show_piece', 'art_show_receipt', ['receipt_id'], ['id'], ondelete='SET NULL')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

from alembic import op
import sqlalchemy as sa
import residue
from sqlalchemy.types import DateTime


try:
Expand Down Expand Up @@ -52,8 +52,8 @@ def sqlite_column_reflect_listener(inspector, table, column_info):


def upgrade():
op.add_column('access_group', sa.Column('start_time', residue.UTCDateTime(), nullable=True))
op.add_column('access_group', sa.Column('end_time', residue.UTCDateTime(), nullable=True))
op.add_column('access_group', sa.Column('start_time', DateTime(), nullable=True))
op.add_column('access_group', sa.Column('end_time', DateTime(), nullable=True))


def downgrade():
Expand Down
8 changes: 4 additions & 4 deletions alembic/versions/1c87fd8da02e_adds_job_visibility_column.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from alembic import op
import sqlalchemy as sa
from sqlalchemy.sql import table
import residue
from sqlalchemy.types import UUID



Expand Down Expand Up @@ -55,9 +55,9 @@ def sqlite_column_reflect_listener(inspector, table, column_info):

dept_membership_request_table = table(
'dept_membership_request',
sa.Column('id', residue.UUID()),
sa.Column('attendee_id', residue.UUID()),
sa.Column('department_id', residue.UUID()),
sa.Column('id', UUID()),
sa.Column('attendee_id', UUID()),
sa.Column('department_id', UUID()),
)


Expand Down
8 changes: 4 additions & 4 deletions alembic/versions/1d2599479473_add_attendee_accounts.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

from alembic import op
import sqlalchemy as sa
import residue
from sqlalchemy.types import UUID


try:
Expand Down Expand Up @@ -54,14 +54,14 @@ def sqlite_column_reflect_listener(inspector, table, column_info):
def upgrade():
# ### commands auto generated by Alembic - please adjust! ###
op.create_table('attendee_account',
sa.Column('id', residue.UUID(), nullable=False),
sa.Column('id', UUID(), nullable=False),
sa.Column('email', sa.Unicode(), server_default='', nullable=False),
sa.Column('hashed', sa.Unicode(), server_default='', nullable=False),
sa.PrimaryKeyConstraint('id', name=op.f('pk_attendee_account'))
)
op.create_table('attendee_attendee_account',
sa.Column('attendee_id', residue.UUID(), nullable=False),
sa.Column('attendee_account_id', residue.UUID(), nullable=False),
sa.Column('attendee_id', UUID(), nullable=False),
sa.Column('attendee_account_id', UUID(), nullable=False),
sa.ForeignKeyConstraint(['attendee_account_id'], ['attendee_account.id'], name=op.f('fk_attendee_attendee_account_attendee_account_id_attendee_account')),
sa.ForeignKeyConstraint(['attendee_id'], ['attendee.id'], name=op.f('fk_attendee_attendee_account_attendee_id_attendee')),
sa.UniqueConstraint('attendee_id', 'attendee_account_id', name=op.f('uq_attendee_attendee_account_attendee_id'))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

from alembic import op
import sqlalchemy as sa
import residue
from sqlalchemy.types import UUID


try:
Expand Down Expand Up @@ -53,8 +53,8 @@ def sqlite_column_reflect_listener(inspector, table, column_info):

def upgrade():
op.create_table('guest_hospitality',
sa.Column('id', residue.UUID(), nullable=False),
sa.Column('guest_id', residue.UUID(), nullable=False),
sa.Column('id', UUID(), nullable=False),
sa.Column('guest_id', UUID(), nullable=False),
sa.Column('completed', sa.Boolean(), server_default='False', nullable=False),
sa.ForeignKeyConstraint(['guest_id'], ['guest_group.id'], name=op.f('fk_guest_hospitality_guest_id_guest_group')),
sa.PrimaryKeyConstraint('id', name=op.f('pk_guest_hospitality')),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

from alembic import op
import sqlalchemy as sa
import residue
from sqlalchemy.types import UUID


try:
Expand Down Expand Up @@ -53,7 +53,7 @@ def sqlite_column_reflect_listener(inspector, table, column_info):

def upgrade():
op.add_column('art_show_application', sa.Column('agent_code', sa.Unicode(), server_default='', nullable=False))
op.add_column('art_show_application', sa.Column('agent_id', residue.UUID(), nullable=True))
op.add_column('art_show_application', sa.Column('agent_id', UUID(), nullable=True))
op.create_foreign_key(op.f('fk_art_show_application_agent_id_attendee'), 'art_show_application', 'attendee', ['agent_id'], ['id'], ondelete='SET NULL')
op.drop_column('art_show_application', 'agent_name')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

from alembic import op
import sqlalchemy as sa
import residue
from sqlalchemy.types import UUID


try:
Expand Down Expand Up @@ -53,7 +53,7 @@ def sqlite_column_reflect_listener(inspector, table, column_info):

def upgrade():
op.create_table('workstation_assignment',
sa.Column('id', residue.UUID(), nullable=False),
sa.Column('id', UUID(), nullable=False),
sa.Column('reg_station_id', sa.Integer(), nullable=False),
sa.Column('printer_id', sa.Unicode(), server_default='', nullable=False),
sa.Column('minor_printer_id', sa.Unicode(), server_default='', nullable=False),
Expand Down
Loading
Loading