Fix the generic placeholder email for attendees #4375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People with just regular attendee badges were tripping the volunteer_placeholder email check because it didn't check a.staffing. They then (correctly) didn't actually get sent the volunteer email because they were not volunteering. Now the volunteer_placeholder function includes a.staffing so people can actually qualify for the generic placeholder. Also fixes an issue where deferred attendees would also qualify for the generic placeholder because I was checking the truthiness of the function itself instead of calling it.
kitsuta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People with just regular attendee badges were tripping the volunteer_placeholder email check because it didn't check a.staffing. They then (correctly) didn't actually get sent the volunteer email because they were not volunteering. Now the volunteer_placeholder function includes a.staffing so people can actually qualify for the generic placeholder.
Also fixes an issue where deferred attendees would also qualify for the generic placeholder because I was checking the truthiness of the function itself instead of calling it.