fix: change header h1 to span for proper heading hierarchy - #1708
Open
Youngmaster0304 wants to merge 1 commit into
Open
fix: change header h1 to span for proper heading hierarchy#1708Youngmaster0304 wants to merge 1 commit into
Youngmaster0304 wants to merge 1 commit into
Conversation
Changed the h1 element in the header to a span element to ensure there is only one h1 per page (the main REFRAME title in VideoEditor). Fixes magic-peach#69 Contributor: Abhinav Jha (@Youngmaster0304) Email: abhinavjha0304@gmail.com GSSoC 2026 Participant
|
@Youngmaster0304 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
level:beginner
Contributor
✅ PR Format Check Passed — @Youngmaster0304Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @Youngmaster0304!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixed heading hierarchy in the main page by changing the header h1 to a span element.
Why
Proper heading hierarchy (h1 → h2 → h3) is important for accessibility and SEO. The page had two h1 elements:
<h1>Reframe</h1><h1>REFRAME</h1>Changes
<h1>to<span>insrc/app/layout.tsx(header)Acceptance Criteria
<h1>on the pageContributor
Abhinav Jha (@Youngmaster0304) | abhinavjha0304@gmail.com
GSSoC 2026 Participant
Fixes #69