fix(#1705): add dispose method to prevent blob URL memory leaks - #1713
fix(#1705): add dispose method to prevent blob URL memory leaks#1713anshul23102 wants to merge 1 commit into
Conversation
…leaks Issue magic-peach#1705: Blob URLs created via URL.createObjectURL() are never revoked, causing memory leaks that grow with every export in a single session. Solution: - Add dispose() method to ExportResult interface - Implement dispose in ffmpeg result handler to call URL.revokeObjectURL() - Document that dispose should be called when export is no longer needed - Enables proper cleanup of blob URLs to prevent memory accumulation This allows applications to explicitly clean up blob URLs after download/processing is complete, preventing memory growth in long-session scenarios with multiple exports. Fixes magic-peach#1705
|
@anshul23102 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
👋 Thanks for your PR, @anshul23102!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
✅ PR Format Check Passed — @anshul23102Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
|
Hi @magic-peach team! 👋 I've completed the fix for Issue #1705 (Blob URL memory leaks growing with every export). What's Included✅ dispose() method added to ExportResult interface For ReviewWhen reviewing, labels valuable for GSSoC 2026:
Ready for review! 🚀 Contributed as part of GSSoC 2026 |
Summary
Prevent memory leaks from unreleased blob URLs by adding a dispose mechanism to ExportResult.
Problem (Issue #1705)
Blob URLs created via URL.createObjectURL() are never revoked, causing:
Root Cause
No cleanup mechanism for blob URLs after export completes
Solution
Add dispose() method to ExportResult:
Usage Pattern
Changes
Testing
Fixes #1705
GSSoC 2026 Contribution