Warn developers of Coming Deprecation of Universal Wallet API Keys #632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request
Adds warning to Universal Wallet API Key app developers of impending doom 😈 of Universal Wallet API Keys. We check for
product_type
to be returned viapostMessage
after the initial call to/config
when we retrieve the theme.When utilizing a UW API Keys the warning will appear as follows for
magic-sdk
and allreact-native
SDK apps:✅ Fixed Issues
N/A
🚨 Test instructions
Run https://github.com/magiclabs/react-native-demo app locally and follow the instructions set here to test.
Reviewer Notes (Optional)
This PR will work in tandem with https://github.com/magiclabs/phantom/pull/3037
Please only add one label:
patch
: Bug Fix?minor
: New Feature?major
: Breaking Change?skip-release
: It's unnecessary to publish this change.📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via: