Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jayhwang sc 87905 gas subsidy change sendgaslesstransaction #638

Merged

Conversation

octave08
Copy link
Contributor

@octave08 octave08 commented Sep 27, 2023

📦 Pull Request

[Provide a general summary of the pull request here.]

Changing wallet.sendGaslessTransaction signature
Adding GaslessTransactionRequest type, which consists of JavaScript primitive types only

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@octave08 octave08 added the minor Increment the minor version when merged label Sep 27, 2023
@octave08 octave08 self-assigned this Sep 27, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #87905: [Gas Subsidy] Change .sendGaslessTransaction signature.

@octave08 octave08 force-pushed the jayhwang-sc-87905-gas-subsidy-change-sendgaslesstransaction branch from ba0ea20 to de8c2ba Compare September 27, 2023 22:04
@octave08 octave08 added patch Increment the patch version when merged and removed minor Increment the minor version when merged labels Sep 27, 2023
@octave08 octave08 force-pushed the jayhwang-sc-87905-gas-subsidy-change-sendgaslesstransaction branch from a82d3f4 to 23bb145 Compare September 28, 2023 06:53
karljin
karljin previously approved these changes Sep 28, 2023
@octave08 octave08 added this pull request to the merge queue Sep 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 28, 2023
@octave08 octave08 added this pull request to the merge queue Sep 28, 2023
Merged via the queue into master with commit 5e77a64 Sep 28, 2023
4 checks passed
@octave08 octave08 deleted the jayhwang-sc-87905-gas-subsidy-change-sendgaslesstransaction branch September 28, 2023 22:07
@Ariflo Ariflo added the released This issue/pull request has been released. label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants