Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useInternetConnection hook to track internet connectivity changes #665

Merged
merged 12 commits into from
Nov 20, 2023
Merged

Add useInternetConnection hook to track internet connectivity changes #665

merged 12 commits into from
Nov 20, 2023

Conversation

romin-halltari
Copy link
Contributor

@romin-halltari romin-halltari commented Nov 14, 2023 •
edited by github-actions bot
Loading

📦 Pull Request

[Provide a general summary of the pull request here.]

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@romin-halltari romin-halltari self-assigned this Nov 14, 2023
@shortcut-integration Shortcut Integration
Copy link

This pull request has been linked to Shortcut Story #75722: [React Native SDK] Add support for general connectivity error from Relayer <:> RN Package.

@romin-halltari romin-halltari added patch Increment the patch version when merged minor Increment the minor version when merged and removed patch Increment the patch version when merged labels Nov 14, 2023
@romin-halltari romin-halltari force-pushed the rominhalltari-sc-75722-react-native-sdk-add-support-for-general branch from a3bd725 to 6bdea14 Compare November 14, 2023 23:05
Ariflo
Ariflo suggested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@Ariflo Ariflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on the overall approach here. LMK 👍

packages/@magic-sdk/react-native-bare/src/index.ts Show resolved Hide resolved
Ariflo
Ariflo suggested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@Ariflo Ariflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments. Looking good!

packages/@magic-sdk/provider/src/core/view-controller.ts Outdated Show resolved Hide resolved
packages/@magic-sdk/provider/src/core/view-controller.ts Outdated Show resolved Hide resolved
packages/@magic-sdk/react-native-bare/README.md Outdated Show resolved Hide resolved
@romin-halltari romin-halltari force-pushed the rominhalltari-sc-75722-react-native-sdk-add-support-for-general branch from 6c2a0fc to 170b74b Compare November 17, 2023 21:04
@romin-halltari romin-halltari force-pushed the rominhalltari-sc-75722-react-native-sdk-add-support-for-general branch from 343e59c to 846912f Compare November 20, 2023 18:43
Ariflo
Ariflo approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@Ariflo Ariflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the updates!

@romin-halltari romin-halltari added this pull request to the merge queue Nov 20, 2023
Merged via the queue into master with commit 8e76cc6 Nov 20, 2023
4 checks passed
@romin-halltari romin-halltari deleted the rominhalltari-sc-75722-react-native-sdk-add-support-for-general branch November 20, 2023 19:09
@Ariflo
Copy link
Contributor

Ariflo commented Nov 20, 2023

🚀 PR was released in @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@Ariflo Ariflo added the released This issue/pull request has been released. label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ariflo Ariflo Ariflo approved these changes

Assignees

@romin-halltari romin-halltari

Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romin-halltari @Ariflo