Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split key device share #678

Merged
merged 27 commits into from
Dec 14, 2023
Merged

Split key device share #678

merged 27 commits into from
Dec 14, 2023

Conversation

Dizigen
Copy link
Contributor

@Dizigen Dizigen commented Nov 30, 2023 •
edited by github-actions bot
Loading

📦 Pull Request

Implements the "Device Share Recovery" flow of our Split Key implementation of the Magic Delegated Key Management System.

The SDK will now cache a web-crypto encrypted version of the Client Share key that has been encrypted with the Magic KMS.

Storing this share user side will allow the DKMS to cut out a call to the client KMS, as the share will be cached device side and decrypt-able with the Magic KMS.

The device share will be encrypted with web crypto generated "AES-GCM" encryption key along with an initialization vector, both of which will be stored to the indexedDB of the client frame as well.

✅ Fixed Issues

SC Tickets

🚨 Test instructions

Talk to our sales department.

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@Dizigen Dizigen added the patch Increment the patch version when merged label Nov 30, 2023
@Dizigen Dizigen self-assigned this Nov 30, 2023
Dizigen added 22 commits December 1, 2023 14:28
@Dizigen
implementation for device share + debug line for extConfig
bfa6298
@Dizigen
update yarn lock
0f4a7c1
@Dizigen
use console.warn so the test makes it to the console output
58c2021
@Dizigen
network hash implementation
21f71eb
@Dizigen
clear device shares when user denies account access + disconnects
6521f8e
@Dizigen
correctly encodes and stores the device share
721c067
@Dizigen
fix the way the iv is retrieved
a9d510b
@Dizigen
debug device share retrieval
530c504
@Dizigen
add device share to magic message request
f4c8fc3
@Dizigen
debugging why deviceShare is not emitted in the payload
29e415a
@Dizigen
remove log lines
90b0f61
@Dizigen
make sure to clear all device share keys at once
fdadce7
@Dizigen
add more log lines to debug multichain error
8951ccb
@Dizigen
await iterate
3f10f7c
@Dizigen
use existing iv and ek to encrypt and decrypt other multichain keys
bfbf401
@Dizigen
move the device share retrieval into the lib itself.
90e2686
@Dizigen
refactor code to move device logic out of view controller
5b44e2a
@Dizigen
add test coverage
914fc08
@Dizigen
update tests
d7ed11f
@Dizigen
update implementation to not deal directly with non-base64 encoded st…
060892c 
…rings
@Dizigen
add asserts for the unit tests
02ff552
@Dizigen
store the iv directly
3bb68d2
@Dizigen Dizigen marked this pull request as ready for review December 6, 2023 20:39
@Dizigen Dizigen requested review from Ariflo and Ethella December 6, 2023 20:50
@Dizigen Dizigen requested review from hcote and mattupham December 6, 2023 20:51
@Dizigen Dizigen added minor Increment the minor version when merged and removed patch Increment the patch version when merged labels Dec 6, 2023
@Dizigen Dizigen added this pull request to the merge queue Dec 14, 2023
Merged via the queue into master with commit 82f1080 Dec 14, 2023
4 checks passed
@Dizigen Dizigen deleted the split-key-device-share branch December 14, 2023 22:04
@Ariflo
Copy link
Contributor

Ariflo commented Dec 14, 2023

🚀 PR was released in @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@Ariflo Ariflo added the released This issue/pull request has been released. label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethella Ethella Ethella approved these changes

@Ariflo Ariflo Awaiting requested review from Ariflo

@hcote hcote Awaiting requested review from hcote

@mattupham mattupham Awaiting requested review from mattupham

Assignees

@Dizigen Dizigen

Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dizigen @Ariflo @Ethella