Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type mismatch for signMessage in solana-ext #691

Merged

Conversation

octave08
Copy link
Contributor

@octave08 octave08 commented Dec 21, 2023

πŸ“¦ Pull Request

[Provide a general summary of the pull request here.]

βœ… Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
# or 
yarn add @magic-ext/[email protected]

@octave08 octave08 added the minor Increment the minor version when merged label Dec 21, 2023
@octave08 octave08 requested a review from karljin December 21, 2023 18:01
@octave08 octave08 self-assigned this Dec 21, 2023
Copy link

This pull request has been linked to Shortcut Story #91622: Type Mismatch in Solana Extension.

@octave08 octave08 force-pushed the jayhwang-sc-91622-type-mismatch-in-solana-extension branch from 0513797 to b236e11 Compare December 21, 2023 18:02
@octave08 octave08 added this pull request to the merge queue Dec 21, 2023
Merged via the queue into master with commit 146b388 Dec 21, 2023
4 checks passed
@octave08 octave08 deleted the jayhwang-sc-91622-type-mismatch-in-solana-extension branch December 21, 2023 19:29
@Ariflo
Copy link
Contributor

Ariflo commented Dec 22, 2023

@Ariflo Ariflo added the released This issue/pull request has been released. label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants