-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pdeexp 1951 lost device event does not emit whitelabel mfa provider #826
Merged
Ethella
merged 18 commits into
master
from
PDEEXP-1951-Lost-Device-Event-Does-Not-Emit-Whitelabel-MFA-provider
Oct 25, 2024
Merged
Pdeexp 1951 lost device event does not emit whitelabel mfa provider #826
Ethella
merged 18 commits into
master
from
PDEEXP-1951-Lost-Device-Event-Does-Not-Emit-Whitelabel-MFA-provider
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦Does-Not-Emit-Whitelabel-MFA Pdeexp 1951 lost device event does not emit whitelabel mfa
β
Β Linked to Bug PDEEXP-1951 Β· Lost Device Event Does Not Emit - Whitelabel MFA |
β¦Does-Not-Emit-Whitelabel-MFA feat: add invalid-recovery-code type to loginWithEmailOtp
β¦t-Whitelabel-MFA-provider
Ethella
previously approved these changes
Oct 22, 2024
Please update your branch and install dependencies again |
Ethella
reviewed
Oct 22, 2024
Ethella
previously approved these changes
Oct 24, 2024
Please fix test |
Ethella
previously approved these changes
Oct 25, 2024
β¦t-Whitelabel-MFA-provider
Ethella
approved these changes
Oct 25, 2024
Ethella
deleted the
PDEEXP-1951-Lost-Device-Event-Does-Not-Emit-Whitelabel-MFA-provider
branch
October 25, 2024 18:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π¦ Pull Request
https://magiclink.atlassian.net/browse/PDEEXP-1951
β Fixed Issues
π¨ Test instructions
Screen.Recording.2024-10-22.at.18.33.14.mov
Please π¨ ONLY ADD ONE π¨ of the following labels, failing to do so may lead to adverse versioning of your changes when published:
patch
: Bug Fix?minor
: New Feature?major
: Breaking Change?skip-release
: It's unnecessary to publish this change.Special Note
Please avoid adding any of the
Priority
labels as they conflict with the labels above βοΈπ¦ Published PR as canary version:
Canary Versions
β¨ Test out this PR locally via: