Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test minimal versions in CI with a pinned lockfile #33

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Test minimal versions in CI with a pinned lockfile #33

wants to merge 4 commits into from

Conversation

ijackson
Copy link
Contributor

@ijackson ijackson commented Aug 1, 2024

With this MR, we:

  • Test that the dependencies declared as minimal in our Cargo.toml do work
  • Avoid trying to do our MSRV tests with recent dependencies
  • Avoid CI breakage in the 1.60 tests due to upstream changes.

@ijackson
Require enum-ordinalise 4.2.1
19e33a4 
4.2.0 does not build, because num-bigint doesn't:

   Compiling num-bigint v0.4.0
error[E0308]: mismatched types
  --> /home/rustcargo/.cargo/registry/src/index.crates.io-6f17d22bba15001f/num-bigint-0.4.0/src/biguint/convert.rs:70:19
   |
70 |         .div_ceil(&big_digit::BITS.into())
   |          -------- ^^^^^^^^^^^^^^^^^^^^^^^ expected `u64`, found `&_`
   |          |
   |          arguments to this method are incorrect
   |
   = note:   expected type `u64`
           found reference `&_`
@ijackson
Add script for generating Cargo.lock for minimal versions tests
e27c598
@ijackson
Run maint/update-minimal-versions
de5f102
@ijackson
CI: Use Cargo.lock.minimal for MSRV tests
7138858
@ijackson
Copy link
Contributor Author

ijackson commented Aug 1, 2024

Oh good, this fixes the CI.

Assuming you like this and merge it, I should rebase #31 and #32 so their CI is fixed. LMK when that would be convenient for you.

@ijackson
Copy link
Contributor Author

ijackson commented Aug 1, 2024

(Also, if you like this, I could make a similar MR against assert-eq-float, which would probably eliminate the override in update-minimal-versions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ijackson