-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magit-tag-release: also read message for --sign/--local-user #5102
Conversation
git tag requires a message for all "heavy" tags that have an associated tag object. --annotate, --sign, and --local-user= all create tag objects. Make magit-tag-release read a message in all of these cases.
609c701
to
bd42458
Compare
If
This difference in behavior is intentional; the user can decide how they want to provide the message. However, I also believe I only considered the case where the user signs tags ("because tags should always be signed"). I.e., it is currently not possible to not sign the tag and also use the minibuffer to write the message. One solution that comes to mind, is to change The special handling would not be removed, instead the
We would of course also have to consider how that affects |
I figured I would retain the spirit of |
If `--sign' or `--local-user' is used but `--annotate' is not, then we don't read the message beforehand and `git tag' thus uses `$EDITOR' to have the edit the message. Make sure `$EDITOR' is `emacsclient'. Also see #5102.
I've fixed that. |
Do you intend |
I intend to make these commands consistent with each other, and with |
I've made chances to increase consistency and separation of concerns. See 2da34f1. |
git tag requires a message for all "heavy" tags that have an associated tag object. --annotate, --sign, and --local-user= all create tag objects. Make magit-tag-release read a message in all of these cases.