Skip to content

Conversation

@MAG-AdamThorn
Copy link
Contributor

@MAG-AdamThorn MAG-AdamThorn commented Oct 29, 2025

Services-level support is being added for Gemini-based services. To ensure usage is managed appropriately, we are also tracking and limiting usage via the quota system. This requires a new Quota Feature Tier type: GoogleGenAI which has been added.

Please note:
MCS have not yet added the type, which means that one of our tests GetTierFeaturesQuota, has had to be temporarily updated to account for this. Currently the GetTierFeaturesQuota returns 9 tiers, but will return 10 once MCS have added the type. Once MCS have done this I will remove the temporary workaround.

Another change I have made to the test is to no-longer validate every property of the returned FeatureQuotaInfo object as its data is subject to change at any point. This is a permanent change and will not be reverted once the new type is added by MCS.

@github-actions
Copy link

🚀 Pull Request Review Guidelines

Thank you for taking the time to review this Pull Request. The following is a summary of our Pull Request guidelines. The full guidelines can be found here.

💬 How to Provide Feedback

We use a comment ladder when leaving review comments to avoid any ambiguity.

Tag Is response required? Is a change required? May the PR author resolve?
[Fix] ✔️ ✔️
[Consider] ✔️ ✔️
[Question] ✔️
[Nit] ✔️
[Comment] ✔️

All comments should be prefixed with one of the above tags, for example:
[fix] Your editor is still set to use tabs instead of spaces, or this file is old and needs to be reformatted.

⚠️ Reviewers should be sure to resolve conversations if they feel their feedback has been addressed sufficiently.

🎯 PR Author Focus Areas

  • Link Commits to Conversations After making a change in response to a reviewer's comment, link the specific commit in the comment thread. This will allow the reviewer to view the change without having to hunt the codebase for it.
  • Breaking Changes Any breaking changes made to the public interface must be specifically called out in the PR. The preferred format is a bullet list enumerating the specific nature of the change/s, as well as the types and method signatures that are affected. If necessary, migration guidance should also be provided here.

Thanks again for taking the time to review this Pull Request.

@MAG-AdamThorn MAG-AdamThorn force-pushed the OF-1805_Add_GoogleGenAI_Quota_Type branch from e0ac897 to 3f93d12 Compare October 29, 2025 14:08
@MAG-AdamThorn MAG-AdamThorn marked this pull request as ready for review October 30, 2025 10:03
@MAG-AdamThorn MAG-AdamThorn requested a review from a team as a code owner October 30, 2025 10:03
Copy link
Contributor

@MAG-ChristopherAtkinson MAG-ChristopherAtkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question]do we have a time line for when the GoogleGenAI with be introduces on the backend?

@MAG-AdamThorn
Copy link
Contributor Author

[Question]do we have a time line for when the GoogleGenAI with be introduces on the backend?

The plan is to inform CHS as soon as this is merged so that they can add it in.

@MAG-AdamThorn MAG-AdamThorn force-pushed the OF-1805_Add_GoogleGenAI_Quota_Type branch from 3f93d12 to 3066471 Compare November 4, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants