Fix: [Removes use of count() on result of find() #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnussolution
force-pushed
the
source
branch
3 times, most recently
from
afa720b to
3a5c052
Compare
magnussolution
force-pushed
the
source
branch
7 times, most recently
from
48dce32 to
b2559cf
Compare
magnussolution
force-pushed
the
source
branch
2 times, most recently
from
f3d3b39 to
b98ebba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Migrations
NO
Description
The find() function on the Yii models return an object or null, and none of these implement Countable, thus count() will fail and the code will not be able to continue. The change in this makes sure that the object is compared in the if statement to give the wanted result, as in True if it is a valid object or False in case of null. Since we do not expect there to be more than one object (which is probably why find was used and not findAll or similar) it makes sense to not check count anyway.
Testing
Tested: Yes, against ca0215e