Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless parentheses around expressions should be removed to prevent any misunderstanding #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,10 @@ public int compare(byte[] b1, int s1, int l1, byte[] b2, int s2, int l2) {
if (thisLeftValue == thatLeftValue) {
long thisRightValue = readLong(b1, s1 + 8);
long thatRightValue = readLong(b2, s2 + 8);
return (thisRightValue < thatRightValue ? -1 : (thisRightValue == thatRightValue ? 0 : 1));
return thisRightValue < thatRightValue ? -1 : (thisRightValue == thatRightValue ? 0 : 1);
}

return (thisLeftValue < thatLeftValue ? -1 : (thisLeftValue == thatLeftValue ? 0 : 1));
return thisLeftValue < thatLeftValue ? -1 : (thisLeftValue == thatLeftValue ? 0 : 1);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public Tuple2<Tuple3<String, String, String>, LogStatistics> call(String logReco
>() {
public Boolean call(Tuple2<Tuple3<String, String, String>, LogStatistics> s) {
Tuple3<String, String, String> t3 = s._1;
return (t3._1() != null); // exclude Tuple3(null,null,null)
return t3._1() != null; // exclude Tuple3(null,null,null)
}
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ static class TupleComparatorAscending
@Override
public int compare(Tuple2<String,Double> t1,
Tuple2<String,Double> t2) {
return (t1._2.compareTo(t2._2)); // sort based on AVF Score
return t1._2.compareTo(t2._2); // sort based on AVF Score
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public String call(Iterable<Tuple2<Long, Long>> values) {
for (Tuple2<Long, Long> t2 : values) {
final Long toUser = t2._1;
final Long mutualFriend = t2._2;
final boolean alreadyFriend = (mutualFriend == -1);
final boolean alreadyFriend = mutualFriend == -1;

if (mutualFriends.containsKey(toUser)) {
if (alreadyFriend) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public Iterable<Map<Character,Long>> call(Iterator<String> iter) {
allBaseCounts.put(base, entry.getValue());
}
else {
allBaseCounts.put(base, (count + entry.getValue()));
allBaseCounts.put(base, count + entry.getValue());
}
}
}
Expand Down