Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ccp::Kvs.set! for fast access #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/ccp/kvs/core.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module Kvs
module Core
def get(k) ; raise NotImplementedError, "subclass resposibility"; end
def set(k,v) ; raise NotImplementedError, "subclass resposibility"; end
def set!(k,v); raise NotImplementedError, "subclass resposibility"; end
def del(k) ; raise NotImplementedError, "subclass resposibility"; end
def keys ; raise NotImplementedError, "subclass resposibility"; end
def exist?(k); !! get(k) ; end
Expand Down
1 change: 1 addition & 0 deletions lib/ccp/kvs/hash.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ def initialize

def get(k) ; decode(@db[k.to_s]) ; end
def set(k,v) ; @db[k.to_s] = encode(v).to_s; end
def set!(k,v); set(k,v) ; end
def del(k) ; decode(@db.delete(k.to_s)) ; end
def count ; @db.size ; end
def clear ; @db.clear ; end
Expand Down
1 change: 1 addition & 0 deletions lib/ccp/kvs/kch.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class Kch < Kyoto::Cabinet
# core
def get(k) ; R{ super }; end
def set(k,v) ; W{ super }; end
def set!(k,v) ; super ; end
def del(k) ; W{ super }; end
def count ; R{ super }; end
def read ; R{ super }; end
Expand Down
6 changes: 6 additions & 0 deletions lib/ccp/kvs/kyoto/cabinet.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ def set(k,v)
kyoto_error!("set(%s): " % k)
end

def set!(k,v)
val = encode(v)
@db[k.to_s] = val or
kyoto_error!("set!(%s): " % k)
end

def del(k)
tryW("del")
v = @db[k.to_s]
Expand Down
1 change: 1 addition & 0 deletions lib/ccp/kvs/tch.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class Tch < Tokyo::Cabinet
# core
def get(k) ; R{ super }; end
def set(k,v) ; W{ super }; end
def set!(k,v) ; super ; end
def del(k) ; W{ super }; end
def count ; R{ super }; end
def read ; R{ super }; end
Expand Down
6 changes: 6 additions & 0 deletions lib/ccp/kvs/tokyo/cabinet.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ def set(k,v)
tokyo_error!("set(%s): " % k)
end

def set!(k,v)
val = encode(v)
@db[k.to_s] = val or
tokyo_error!("set!(%s): " % k)
end

def del(k)
tryW("del")
v = @db[k.to_s]
Expand Down
2 changes: 1 addition & 1 deletion lib/ccp/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Ccp
VERSION = "0.5.0"
VERSION = "0.5.1"
end
1 change: 1 addition & 0 deletions spec/kvs/core_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
it { should respond_to("ext") }
it { should respond_to("get") }
it { should respond_to("set") }
it { should respond_to("set!") }
it { should respond_to("del") }
it { should respond_to("keys") }
it { should respond_to("touch") }
Expand Down
10 changes: 10 additions & 0 deletions spec/kvs/kvs_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -111,5 +111,15 @@
kvs.codec!(:msgpack).should == kvs
end
end

describe "#set!" do
specify do
kvs.W! if klass.ext != "hash"
kvs.codec! :json
kvs.count.should == 0
kvs.set!("a", 1)
kvs["a"].should == 1
end
end
end
end