Improve parsing of MIME parameter part #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Any news on this? Should be an easy-picking! |
|
Can one of the admins verify this patch? |
stefanw
force-pushed
the
same-param-encoded-unencoded
branch
from
be39322
to
a4bab03
Compare
stefanw
force-pushed
the
same-param-encoded-unencoded
branch
from
a4bab03
to
c38b320
Compare
Fix problem where single encoded + unencoded MIME parameter of same name get concatenated.
stefanw
force-pushed
the
same-param-encoded-unencoded
branch
from
c38b320
to
834c850
Compare
thomasst
added a commit
to closeio/flanker-new
that referenced
this pull request
Mar 20, 2020
- Fix problem where single encoded + unencoded MIME parameter of same name get concatenated (thanks to @stefanw at mailgun/flanker#103) - Prevent concatenating any splitted and unsplitted parameters - Improve docstring of concatenate()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have mails with MIME headers like this:
The parameter
nameandfilenameare present as single encoded and single unencoded. This leads to an interpretation as a parameter continuation and to a concatenation of the values so that the result would be "30676_2015.pdf30676_2015.pdf".I added code to avoid joining parameter values of the same name if they are not actually continuations, but just different encodings of the same value. Test is included!