encode/decode enhancement #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
wonder is this repo actively maintained? |
frankobe
force-pushed
the
aggregate-encode
branch
from
09b414d
to
08fc30c
Compare
frankobe
force-pushed
the
aggregate-encode
branch
from
ebc3c3a
to
34df5f5
Compare
frankobe
force-pushed
the
aggregate-encode
branch
from
4b1f4e8
to
17bacd7
Compare
|
It is still maintained and we're slowly trying to chip away at these older issues. Sorry for letting it languish! If you're still interested could you rebase on master to cleanup the diff and collapse the fix commits? |
|
@b0d0nne11 sure, I can do it, need some time to rebase my memory though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 3 encoding/decoding problems during my daily usage of flanker, tests case from real life added
poor support of Chinese encoding including 'gb2312', 'gbk' and 'gb18030'
heavily rely on
_guess_and_convert, ignore context-type as demonstrated by test emailcharset-gb2312.emlcant handle encode word data corruption caused by encode word separation into multi lines as demonstrated by test case
encodedword_test