Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset state properly #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Reset state properly #4

wants to merge 3 commits into from

Commits on Jun 11, 2018

  1. Don't remove HELO/EHLO domain on RSET

    Per RFC 5321, sections 4.1.1.5 and  4.1.4, issuing an RSET command
    should not result in the HELO/EHLO domain being removed from the
    session.
    
    From section 4.1.1.5:
    
    > It is effectively equivalent to a NOOP (i.e., it has no
    > effect) if issued immediately after EHLO, before EHLO is
    > issued in the session, after an end of data indicator has
    > been sent and acknowledged, or immediately before a QUIT.
    
    And:
    
    > Since EHLO implies some additional processing and response by the
    > server, RSET will normally be more efficient than reissuing that
    > command, even though the formal semantics are the same.
    dcormier committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    3071dd0 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2018

  1. Reset values on subsequent HELO/EHLO commands

    Based on RFC 5321, section 4.1.4, any stored values should be reset
    if a HELO/EHLO command is sent subsequent to the original:
    
    > An EHLO command MAY be issued by a client later in the session.  If
    > it is issued after the session begins and the EHLO command is
    > acceptable to the SMTP server, the SMTP server MUST clear all buffers
    > and reset the state exactly as if a RSET command had been issued.  In
    > other words, the sequence of RSET followed immediately by EHLO is
    > redundant, but not harmful other than in the performance cost of
    > executing unnecessary commands.
    dcormier committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    074b367 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6660dbc View commit details
    Browse the repository at this point in the history