Types for ember-cookies

[And012]

No description provided.

[BobrImperator]

Hi, thanks for the PR.

It seems like the package.json is missing types configuration key, which should point to the index.d.ts file. See https://github.com/mainmatter/ember-simple-auth/pull/2514/files#diff-4224f4bb715c8d1383afd410185b784b261a6dec77e2ebdbe329477d4f52d013R15

[BobrImperator]

It seems like this dependency is extraneous, since the index.d.ts is not extending any of the Ember types?

[And012]

Thanks for the comment make sense. I will update the pr

[BobrImperator]

The PR looks good, there are 2 things missing though before we can merge it.

• We might want to add @ember/types back for autocomplete while modifying the index.d.ts.
  Previously it wasn't needed because the PR didn't use any of the Ember objects, but now it does.

• We should make sure that the index.d.ts is shipped to the npm registry.
  Currently it's missing from the tarball that is produced by npm publish, see:
  

You can manually test this by running these commands:

• npm publish --dry-run, it'll run all the build commands as if it was about to publish the package to the registry.
• npm pack, it'll produce a tarball like on the screenshot above.

[BobrImperator]

Looks good to me 🙌

[BobrImperator]

Released https://github.com/mainmatter/ember-cookies/releases/tag/v1.1.0-re-release.2