Map timezones of the form GMT-0800 to corresponding Olson names
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://bugs.horde.org/ticket/15054 [#15054] Thunderbird "all workday" events become "daily" events
See https://bugs.horde.org/ticket/15054 [#15054] Thunderbird "all workday" events become "daily" events Update metadata and workflows for PHP 8 support PHP 8.1: use 'now' rather than null for current date Fix [#15054] Thunderbird-generated events issue See https://bugs.horde.org/ticket/15054 [#15054] Thunderbird "all workday" events become "daily" events Add unit test for bug #15054
ralflang
pushed a commit
that referenced
this pull request
Oct 26, 2023
PHP 8.1: use 'now' rather than null for current date
ralflang
force-pushed
the
FRAMEWORK_6_0
branch
from
7026574 to
7b44dd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've encountered some calendar events that I've imported to my desktop calendar but fail to sync to Horde Kronolith, emitting errors like this:
This PR adds support for converting those to Olson names, and adds a few test cases. (Olson only defines names for integer offsets, not for quarter-hour offsets, so the last test case ensures this change at least doesn't make the situation worse for those.)
(BTW, thanks for your work updating Horde for PHP 8!)