update changes to the black- and whitelist instead of rewriting all entries every time #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntries every time
boekhorstb1
pushed a commit
that referenced
this pull request
Jun 4, 2024
Feature transport sieveconnect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewriting the whole list every time can lead to long load times especially if sql clusters are used.
There is one problem with this fix: The displayed order of addresses will always be the insertion order, which is not necessary the order inputed in the frontend. That could potentially confuse users.
Since the order does not matter in the backend we could make it more consistent by always showing the addresses in alphabetical order.