[IMP] base_tier_validation: Make validation_status field stored

This backports changes from OCA/18.0:
- PR OCA#1138: Make validation_status field stored for better search performance
- PR OCA#1139: Add migration script to prevent errors during upgrade

Changes:
* base_tier_validation: Add store=True to validation_status field
* base_tier_validation: Add migration script to populate stored field
* base_tier_validation_forward: Update test to use validation_status
* Version bumps for both modules

Author: maisim

base_tier_validation/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "Base Tier Validation",
     "summary": "Implement a validation process based on tiers.",
-    "version": "16.0.2.3.0",
+    "version": "16.0.2.4.0",
     "development_status": "Mature",
     "maintainers": ["LoisRForgeFlow"],
     "category": "Tools",

base_tier_validation/migrations/16.0.2.4.0/post-migration.py

@@ -0,0 +1,59 @@
+# Copyright 2025 OCA
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+
+from openupgradelib import openupgrade
+
+
+def populate_validation_status_field(env):
+    """Populate the validation_status field for all existing tier validation records."""
+    # Query to find all tables that have the validation_status column
+    # This prevents errors when the field doesn't exist in some models
+    env.cr.execute(
+        """
+        SELECT table_name
+        FROM information_schema.columns
+        WHERE column_name = 'validation_status'
+        AND table_schema = current_schema()
+    """
+    )
+
+    tables_with_validation_status = [row[0] for row in env.cr.fetchall()]
+
+    for table_name in tables_with_validation_status:
+        try:
+            # Convert table name to model name (basic conversion)
+            model_name = table_name.replace("_", ".")
+
+            # Check if the model exists in the registry
+            if model_name in env.registry:
+                model = env[model_name]
+
+                # Check if it inherits from tier.validation
+                if hasattr(model, "_inherit") and "tier.validation" in (
+                    model._inherit
+                    if isinstance(model._inherit, list)
+                    else [model._inherit]
+                ):
+                    # Get records that need validation_status computation
+                    records = env[model_name].search([])
+                    if records:
+                        # Compute validation_status for all records in batches
+                        batch_size = 1000
+                        for i in range(0, len(records), batch_size):
+                            batch = records[i : i + batch_size]
+                            batch._compute_validation_status()
+                            env.cr.commit()
+
+        except Exception as e:
+            # Log error but continue with other models to prevent migration failure
+            openupgrade.logged_query(
+                env.cr,
+                f"-- Warning: Could not populate validation_status for "
+                f"table {table_name}: {str(e)}",
+            )
+
+
+@openupgrade.migrate()
+def migrate(env, version):
+    """Migrate validation_status field to be stored."""
+    populate_validation_status_field(env)

base_tier_validation/models/tier_validation.py

@@ -58,6 +58,7 @@ class TierValidation(models.AbstractModel):
         ],
         default="no",
         compute="_compute_validation_status",
+        store=True,
     )
     reviewer_ids = fields.Many2many(
         string="Reviewers",

base_tier_validation_forward/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "Base Tier Validation Forward",
     "summary": "Forward option for base tiers",
-    "version": "16.0.1.1.3",
+    "version": "16.0.1.1.4",
     "category": "Tools",
     "website": "https://github.com/OCA/server-ux",
     "author": "Ecosoft,Odoo Community Association (OCA)",

base_tier_validation_forward/tests/test_tier_validation.py

@@ -131,4 +131,4 @@ def test_01_forward_tier(self):
         wizard.comment = "Forward tier is reviewed"
         wiz = wizard.save()
         wiz.add_comment()
-        self.assertTrue(record.validated)
+        self.assertEqual(record.validation_status, "validated")