Fixed tests to work with windows file separator too using OS agnostic… #23
Conversation
… DIRECTORY_SEPARATOR
…hat are failing that I can't figure out.
majkel89
changed the title
majkel89
changed the title
| @@ -26,13 +26,13 @@ class ExtCaseInsensitiveGeneratorTest extends TestBase | |||
| public function testGenerator() | |||
| { | |||
| $extensions = array(); | |||
| $generator = new ExtCaseInsensitiveGenerator('some/FILE.php'); | |||
| $generator = new ExtCaseInsensitiveGenerator('some'.DIRECTORY_SEPARATOR.'FILE.php'); | |||
There was a problem hiding this comment.
I would leave the paths as it was before. The constant decreases readability
| @@ -142,15 +143,15 @@ public function setLength($length) { | |||
| } | |||
|
|
|||
| /** | |||
| * Returns filed decimalCount | |||
| * Returns field decimalCount | |||
There was a problem hiding this comment.
Thanks for pointing out the typos
| array('123', 123.0), | ||
| array(123, 123.0), | ||
| array(' 2', 2.0), | ||
| array('1234.1234', 123.0), |
There was a problem hiding this comment.
strange that in this test the fraction part is stripped
|
Please fix the tests |
| * @throws Exception | ||
| */ | ||
| public function testReadDbase4() { | ||
| $dbf = Table::fromFile('tests/fixtures/dBase4.dbf'); |
There was a problem hiding this comment.
This test fails because it cannot find corresponding memo file (fbt)
There was a problem hiding this comment.
is that FPT format? How do you choose one over the other?
In readme I see:
Supported memo formats
- DBT
- FPT
In the failed test I see:
- org\majkel\dbase\DBase4Test::testReadDbase4
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-memo1
+▒▒
+memo1
| $header = $this->reflect($format)->createHeader($this->getHeaderData(array( | ||
| 'v' => 666, | ||
| ))); | ||
| self::assertTrue($header->isValid()); |
There was a problem hiding this comment.
Please investigate why this test fails. The only case where the header could be invalid is when the calculated records count does not match file size
There was a problem hiding this comment.
I see what is going on here.
It is using bitwise logic here.
return $header->setValid($header->getVersion() & $this->getVersion());
So with dBase4 I need to use 668 for the test since it will be doing 668 & 4 in the above setValid method. And 4 in binary is 100. I have to choose a number that has its bit flipped in the 3rd spot and 666 doesn't do this but 668 does.
668 is 0010 1001 1100 in binary.
… DIRECTORY_SEPARATOR