Skip to content

Conversation

@nhasselmeyer
Copy link
Collaborator

Currently, the issue list printed by geordi branch and geordi commit interleaves issues in different teams, leading to lists like

1. [A-123]
2. [A-124]
3. [B-12]
4. [A-130]
5. [B-13]
6. [A-131]

Even when multiple teams are configured, I usually know which team the issue I want to select belongs to. Sorting the list by team then state would allow me to limit my search to the relevant section of the list.

Comment on lines +42 to +43
team_ids = settings.linear_team_ids
issues.sort_by! { |i| [team_ids.index(i.dig('team', 'id')), -i.dig('state', 'position')] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have a test for this new behavior. I know it's a bit more difficult because we need to stub the linear responses but if we care about ordering I'd like to make sure the behavior is tested.

@brunosedler
Copy link
Contributor

After some discussion in the team, we came to the conclusion, that we're not going to implement this kind of sorting. The change has little relevance for most people in our team, and we don't see that much benefit in the sorting, because, for example the least progressed issues aren't always at the bottom anymore, but may become harder to find somewhere in the middle of the list.

We agree, that sorting might help in some cases but we think the sorting would need to be more sophisticated, respectively the CLI output or flow would need to change to make a real improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants