Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix actions convertion and handle disabled actions #5

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

jbcr
Copy link
Contributor

@jbcr jbcr commented Jan 3, 2024

Fix error introduced in the previous PR #3.

  • The actions configuration value must be an array or iterable. But the condition is always wrong if the value is an array.

  • Fix convert the options for all default actions (create, edit, delete...).

  • The realpath result is false if the file does not exist. This PR change the behavior to check if the output directory is ready before processing and throws an exception if the result of realpath is false.

This code has been tested on a real project with Sylius 1.12.

@mamazu mamazu merged commit 6b768ec into mamazu:master Jan 5, 2024
1 check failed
@mamazu
Copy link
Owner

mamazu commented Jan 5, 2024

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants