-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initialize Tandy Color Computer cassette software list #12505
base: master
Are you sure you want to change the base?
Conversation
You also need to hook it up in the relevant driver files using a line like this:
|
- init TRS-80 Color Computer cassette software list (coco_cass) - workaround for batocera.linux/11781 - register coco_cass software list for COCO/COCO3 - add src of cassette images
is the automated CI build passing sufficient to request a merge of this pull request? I have very limited hardware & last I tried my own local build, I believe it ran out of memory. I originally thought this was a submission of a single XML file & didn't anticipate any code changes until this was pointed out to me. I am wondering if it is acceptable to request a merge given how straightforward the changes are. is there any way to download the Linux build of MAME from CI for me to verify these changes worked? |
The appending of "1" to all software names will not be accepted. The issue should be addressed in Batocera rather than adding meaningless numbers to names. You don't need the publisher duplicated in brackets in the software description, unless the same title was released by different publishers. Why do you have a both a .cas and .wav for Zaxxon? Are they effectively the same data in different formats? And I'd be surprised if both the .cas and .wav were exactly the same size of 3700 bytes. In fact all of your files are listed with size of 3700 bytes which I highly doubt to be correct. |
Yes, you can download the built artifacts. Expand the 'All checks have passed' part by clicking 'Show all checks'. This will display all the tests, then click 'Details' for one of the tests you're interested in, click 'Summary' at the top left then in the bottom right you can see and download the artifacts. |
Also, I believe that credit for softlist items should go in the PR description rather than the xml. Else there will be a lot of work left to do to go back and add everyone in all of them (would be awkward to all contributors if it was a "friends only" thing). |
In case it wasn't clear: MAME accepts a root XML as input of a SW item, so:
|
thank you so much @wilbertpol for the tip! I really like the build environment here - it’s very supportive & quite functional :) I verified the Linux build loads The issue I’m running into now is it’s not automatically mounting the cassette image (I verified this by opening up the MAME File Manager and see no cassette image is mounted) - I poked around again through the code trying to understand how the software list is mapped to devices. My best guess is
removed and will coordinate with the Batocera Linux team
removed all references that were duplicates.
@Pernod70 yes - they are two accepted formats and thank you for catching the incorrect sizes - I’ve updated all the sizes for all images to exact byte counts.
@ICEknigh7 could you elaborate on this a bit more? I’m initializing the cassette list with software titles I actually own. I do not have the hardware to make my own dumps so I made sure to acknowledge the source of the images from colorcomputerarchive.com |
My understanding is that softlists are for software info and credits should go in the PR description. |
ok - I added a bulleted summary of this PR and a list of software titles to the original PR request above:
|
...Why did you readd the credits to the xml (c38ed6e)? |
Commit Summary
Software Titles
Cassette images downloaded from https://www.colorcomputerarchive.com
Other details
In preparation, we’ve implemented coco autoload behavior in Batocera Linux and the option to search a cassette software list in Advanced Game Options for a coco software item.
Historical (dev issue resolved)
This is a draft pull request because the following command does not find
coco_cass.xml
in the specified hash path (/var/run/mame_software/hash
):A nearly identical command line boots just fine for the coco diskette software list:
I’ve verified the hash file is in the specified hash path and it is a valid, world-readable XML file.
The error MAME reports (listing no matches):
I’ve double checked the checksum
7c949bd685a5db980dda034237564d6956654995
is correct.I’ve reviewed the codebase and couldn’t find any reference to anything that is hardcoded when it comes to software lists (this is based on my limited understanding of how software lists work in MAME)
Could someone please verify the syntax of the new software list is correct and if there are any changes to the MAME codebase that needs to happen for the above MAME command to work?
Thank you in advance for your support integrating this contribution into MAME!