Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a NOT WORKING machine (Rock Fever) #12609

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

zxcwdta
Copy link

@zxcwdta zxcwdta commented Jul 23, 2024

NOT WORKING machine

Rock Fever 1 (IGS)

@zxcwdta zxcwdta changed the title Added a NOT WORKING machine RF1 Added a NOT WORKING machine (Rock Fever 1) Jul 23, 2024
@zxcwdta zxcwdta closed this Jul 23, 2024
@zxcwdta zxcwdta reopened this Jul 23, 2024
@mamehaze
Copy link
Contributor

I think this is more than just "/* need internal rom of IGS027A */" as there don't seem to be any dumps listed, not even NO DUMPs of anything other than the program ROMs.

ROM_LOAD16_BYTE ( "rf1_sys_h.u32", 0x00000, 0x80000, CRC(e5e1e5f9) SHA1(1e8e4b7e53fcab68d14f36f9c8d85047f308bc93) )
ROM_LOAD16_BYTE ( "rf1_sys_l.u31", 0x00001, 0x80000, CRC(ee2c3817) SHA1(490e879f347ac38feaad80666d28fac9e2154188) )

ROM_REGION( 0x4000, "prot", 0 ) /* ARM protection ASIC - internal rom */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will break validation if you leave empty ROM_REGIONs. You should add ROMREGION_ERASE00 or ROMREGION_ERASEFF (like you did for the "sprmask" region) to avoid this.
To check validation doesn't complain, just do mame -validate

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the tips and suggestions. I will fix it shortly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run mame -validate and it appears to be fine now.

@mamehaze
Copy link
Contributor

mamehaze commented Jul 23, 2024

apparently this is some kind of custom board + PC combo in a dedicated cabinet.

the lack of any kind of documentation of what this is isn't really acceptable as-is IMHO. It isn't even clear if it should be using regular PGM BIOS ROMS for text etc. or if those weren't present either.

@zxcwdta
Copy link
Author

zxcwdta commented Jul 23, 2024

I think this is more than just "/* need internal rom of IGS027A */" as there don't seem to be any dumps listed, not even NO DUMPs of anything other than the program ROMs.

Most assets are missing right now as I haven't got time to make an adapter that plugs in the ROM board to dump each chip. Will do that and archive them once it's been properly dumped.

@mamehaze
Copy link
Contributor

I think this is more than just "/* need internal rom of IGS027A */" as there don't seem to be any dumps listed, not even NO DUMPs of anything other than the program ROMs.

Most assets are missing right now as I haven't got time to make an adapter that plugs in the ROM board to dump each chip. Will do that and archive them once it's been properly dumped.

they should be listed as NO_DUMP at least. Likewise needs comment about it using PC hardware for the video etc. too (which will also need dumping at some point)

@zxcwdta
Copy link
Author

zxcwdta commented Jul 23, 2024

I think this is more than just "/* need internal rom of IGS027A */" as there don't seem to be any dumps listed, not even NO DUMPs of anything other than the program ROMs.

Most assets are missing right now as I haven't got time to make an adapter that plugs in the ROM board to dump each chip. Will do that and archive them once it's been properly dumped.

they should be listed as NO_DUMP at least. Likewise needs comment about it using PC hardware for the video etc. too (which will also need dumping at some point)

Will make some changes to the code and document the board later. The architecture is very similar to PGM as it uses 68K for the main program and has the IGS027 for other purposes (DRM or sound? not sure yet.).

@mamehaze
Copy link
Contributor

mamehaze commented Jul 23, 2024

actually I don't know if there was a PC side at all, there seems to be conflicting information on this, so yes please provide full information so we know what it is at least!

we need to know if it uses the same video and sound chips as PGM too, which are as important as 68k and 027A for deciding if it belongs in this driver.

@zxcwdta
Copy link
Author

zxcwdta commented Jul 23, 2024

actually I don't know if there was a PC side at all, there seems to be conflicting information on this, so yes please provide full information so we know what it is at least!

we need to know if it uses the same video and sound chips as PGM too, which are as important as 68k and 027A for deciding if it belongs in this driver.

The very first Rock Fever uses 68K for main program, IGS023 for video processing, and an IGS027, probably for copy protection or sound processing.
Subsequent releases, Rock Fever EX, 3, 3 Plus and 3.5 MAX, share the same PCB, where two IGS027s are used, the graphics system remains unchanged (IGS023).
Rock Fever 4 and 5 are PC-based games. They used IGS027 for handling IO, and later models the 027 was replaced with IGS036.

Information about this series is sparse, but I will create a diagram for documenting the board and add it to the file.

@Hammy1986
Copy link

Hammy1986 commented Jul 23, 2024

actually I don't know if there was a PC side at all, there seems to be conflicting information on this, so yes please provide full information so we know what it is at least!

we need to know if it uses the same video and sound chips as PGM too, which are as important as 68k and 027A for deciding if it belongs in this driver.

My friend has Rock fever 3 plus to dump soon, there is NO PC , it's a pgm-like mainboard with all the content on several "rom cards / simms" similar to the CPS3.

If a way to dump the "carts" quickly is made, please contact me about it... Cheers!

@zxcwdta zxcwdta requested a review from Osso13 July 24, 2024 03:05
Copy link
Member

@Osso13 Osso13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, here are some small notes.

src/mame/igs/pgm.cpp Outdated Show resolved Hide resolved
src/mame/igs/pgm.cpp Outdated Show resolved Hide resolved
src/mame/igs/pgm.cpp Outdated Show resolved Hide resolved
src/mame/igs/pgm.cpp Outdated Show resolved Hide resolved
@zxcwdta zxcwdta changed the title Added a NOT WORKING machine (Rock Fever 1) Add a NOT WORKING machine (Rock Fever) Jul 24, 2024
@mamehaze
Copy link
Contributor

NO_DUMP lines don't need to be commented out; it won't list the NO_DUMPs when MAME starts, or in MAME's XML output if they're commented out

@happppp
Copy link
Member

happppp commented Jul 24, 2024

More letters for the shortname please? Like rfever.
rf, yeah it's not taken yet, but not descriptive at all. And if everyone did it, we'd run out quick ;)

@mamehaze
Copy link
Contributor

also rf2 is taken, which would cause problems later when adding rock fever 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants