casio/pv1000.cpp: Toggle BUSREQ like hardware does #12623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelosa
reviewed
Jul 30, 2024
src/mame/casio/pv1000.cpp
Outdated
| { | ||
| int hpos = m_screen->hpos(); | ||
| int vpos = m_screen->vpos(); | ||
| hpos += 32; // adjust from screen coordinates to something that's easier to math |
There was a problem hiding this comment.
MAME historically starting at origin 0,0 is just for a generic stub convenience.
This kind of math is unnecessary if you acknowledge overscan origins in screen_update and set_raw setups.
There was a problem hiding this comment.
To further clarify, if you do set_raw with the real hcount/vcount values you also have to change where you draw in screen_update to coincide with the specified visible area. I get why MAME does that, but it really does violate the principle of least surprise.
…ames to realistic speeds try adjusting geometry to simplify busreq timing
|
Is this acceptable now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slows down games to realistic speeds.
Please let me know if there's a better way to do any of this.