att6300p.cpp: Add support for 1.2MB drive (525hd) #14577
Conversation
|
I'd say just move this to the actual driver since it's on the motherboard. It's small enough that it can probably just go right in the driver, or you can add it as a separate device in mame/olivetti. |
|
OK, I did the latter - should be good to go. |
|
Almost there. For motherboard devices added via a slot mechanism, you can use set_fixed() to prevent the user from changing them. For the most directly applicable example, the Kaypro 16 PC luggable in pc.cpp does this to lock down the ISA slots it uses: subdevice<isa8_slot_device>("isa1")->set_fixed(true); |
I thought that's what the last parameter was doing? If I change it to "false", I can change the device in the "Slot Devices" menu (well, it lets me choose between fdc_6300p or nothing, since there's only one option), otherwise the menu won't let me change it. |
|
isa8_slot_device(const machine_config &mconfig, const char *tag, device_t *owner, uint32_t clock, T &&isa_tag, U &&opts, const char *dflt, bool fixed) Yes, the last bool parameter is the value of "fixed". |
| FLOPPY_CONNECTOR(config, "fdc:0", att6300p_floppies, "525hd", isa8_fdc_device::floppy_formats).enable_sound(true); | ||
| FLOPPY_CONNECTOR(config, "fdc:1", att6300p_floppies, "525dd", isa8_fdc_device::floppy_formats).enable_sound(true); |
There was a problem hiding this comment.
Is 525hd and 525dd a mistake or the sizes are really uneven by factory default? (I'd add a comment if latter)
There was a problem hiding this comment.
That's the way they are by factory default, according to the User Guide. I can add a comment.
|
I didn't mean to push that last commit to this PR/branch since it's unrelated. But the commit is good from my point of view. Let me know if I should back it out and submit a new PR for it. Sorry for the confusion. |
Looks a fairly standard x86 A20 gate control. It's fine as long as it's mentioned in the PR OP message. |
4 participants
The standard configurations for the 6300 Plus have drive A as a 1.2MB floppy, with either a hard drive or a 360K floppy as a secondary drive. One thing that's unique to the 6300 Plus is that port 0x65 is used for data rate control.
Since the FDC is on the motherboard, isa8_fdc_6300p_device is unique to the 6300 Plus... I'm wondering if it should go in a machine-specific file, instead of in fdc.cpp?