-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add embed ext text #8
base: master
Are you sure you want to change the base?
Conversation
if there are no comments on this one, i'll merge it in. |
@mamund How will the client know how to render it without further information of the content-type on the other end of the link? With the "render": "image" directive, the client knew that it was an image/* and could make some assumptions. |
hmm.... good point! proly why i'd used "image" in the original design! so, i suspect that the use of "embed" will also mean the need for a type {name: "content", value:"http://....", render:"embed",type:"text/plain"} right? mca+1.859.757.1449 On Mon, Oct 22, 2012 at 12:18 PM, Cameron Bytheway <[email protected]
|
Yeah I think that would be a good idea. Would we then use the following for images? {"name": "content", "value":"http://....", "render":"embed", "type":"image/png"} |
yeah - that's the implication here. the optional use of "type" property on mca+1.859.757.1449 On Mon, Oct 22, 2012 at 12:38 PM, Cameron Bytheway <[email protected]
|
Also would the type instruct the client to send "Accept: text/plain" when it makes the request? With that we could add some CR support to CJ. |
yep - this is the outcome. adding "type" to data elements increases the CR mca+1.859.757.1449 On Mon, Oct 22, 2012 at 12:45 PM, Cameron Bytheway <[email protected]
|
I'd be fine with this extension with the |
frankly, i'm a bit hesitant to add more factors into this particular mca+1.859.757.1449 On Mon, Oct 22, 2012 at 1:02 PM, Cameron Bytheway
|
I guess the only reason I can think of for not doing is overcomplicating the client/spec. I guess we'd have to decide if it's worth it. |
yep - you're right on there. i'd like to keep the parsing/computing complications at runtime relatively however. as long as we keep the additions optional and as enhancements to mca+1.859.757.1449 On Mon, Oct 22, 2012 at 1:18 PM, Cameron Bytheway
|
I think this is a pretty safe extension. The clients that don't recognize the |
yeah - this case is ok. i am speaking in general here, too. keeping this particular design rather basic in regards to inline H-Factors as long we that stys true, i'm cool w/ the extensions in general. a few of just sayin' mca+1.859.757.1449 On Mon, Oct 22, 2012 at 1:47 PM, Cameron Bytheway
|
I'm doing some experiments having type as property of data and I welcome this addition to the spec, but in this case I think this example goes in the wrong direction: {"name": "content", "value":"http://....", "render":"embed", "type":"image/png"} it spreads what is basically a link information (like in Web Linking) over the value and type properties, when in fact that belongs to something like "value": {"href":"...", "type":"{mimetype}"... but now brings back the issue of representing more than flat structures with CJ... :) |
it spreads what is basically a link information (like in Web Linking) over not sure i follow this. can you expand? mca+1.859.757.1449 On Thu, Oct 25, 2012 at 4:53 PM, Vlad Stirbu [email protected]:
|
I've spent the last days looking at geojson and json schema, and started to expect the "type" property to indicate the data type, either a simple type (e.g. string, number, array, boolean, etc) or complex types (e.g. Point or Polygon in geojson). So, yesterday (and quite late here) it felt odd to see a mimetype as the value of "type"... Now that you know a bit more about the context when I made the comment, I still think that: {"name": "content", "value":"http://....", "render":"embed", "type":"image/png"} is an ad-hoc flattening of something that should look like: {"name":"content", "value":{"href":"http://....", "type":"image/png"}} Maybe I did not understood the problem too well, but looking at the other thread that discusses the inline-collection vs. your proposal in which the hierarchy is established with a "parent" property, I ended up not liking any! So, is the extension proposal in this thread just a way to slip around the issue of being able to handle in a consistent way more than a flat k-v with CJ? Vlad |
@vstirbu would |
not really. I think that a more appropriate way would be to change the {"name": "content", "href":"http://....", "render":"embed", "type":"image/png"} then |
added "embed" as valid option for "render" param. for use when you want inline rendering, but are not linking to an image (i.e. HTML.IFRAME).
looking for feedback.