Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change transclude from string to boolean in JSON example #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smizell
Copy link
Contributor

@smizell smizell commented May 9, 2014

I was working on the schema for this example and it failed with the transclude since it was a string and I was looking for a boolean. I changed the example on Hyperschema.org to make it validate. Do you want transclude to be a boolean in the JSON format?

@mamund
Copy link
Owner

mamund commented May 9, 2014

pretty sure this is going to morph into another "magic string"
enumeration[1]. right?

[1] #24

@smizell
Copy link
Contributor Author

smizell commented May 9, 2014

Yes, I agree. I was writing the schema to the current spec state. When the spec changes, I'll convert that over to an enumeration.

When the change happens, will the spec change to a new version? If so, I could refer to the current schema as 1.0 and then make a new schema for the next version with the new transclude functionality. Or is all the current change proposals for a final 1.0?

@mamund
Copy link
Owner

mamund commented May 9, 2014

spec is "floaty" but will def mark an internal v change for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants