Skip to content

Commit

Permalink
wip: End of debug for today
Browse files Browse the repository at this point in the history
The linker fails to find symbols eventhough they are present
in both `libprotobuf.dll` and the `libprotobuf.lib`.

This has been checked:

 - `protoc` and `libprotobuf` have the same version (3.20.3)
 - the linker call for the ultimate target, `arcticdb_ext`,
 correctly contains the path to `libprotobuf.lib`
 - `arcticdb_core_static` links successfully while containing
 the objects of the C++ source files generated by `protoc`
 - the presence of the 5 symbols reported as "missing" has been
 checked with `dumpbin` and Dependencies [1] and they are present
 as exported in both `libprotobuf.dll` and `libprotobuf.lib`.

This has been tried:
 - using `OBJECT` for building intermediary targets.

This has not been tried:
 - checking toolchains and ABI version compatibility with
 conda-forge's
 - creating an executable which depends on `arcticdb_core_static`
 observing if any other specific problems occurs

This commit removes the dependence on `libprotobuf-lite` which is
redundant with `libprotobuf`.

1: https://github.com/lucasg/Dependencies
2: https://protobuf.dev/support/version-support/#python
  • Loading branch information
jjerphan committed Jul 6, 2023
1 parent 15bf7f9 commit d00fbd5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp/arcticdb/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ set (arcticdb_core_libraries
prometheus-cpp::pull
${standard_libraries}
fmt::fmt
${Protobuf_lite_LIBRARY}
# ${Protobuf_lite_LIBRARY}
${Protobuf_LIBRARY}
${LZ4_LIBRARY}
${Zstd_LIBRARY}
Expand Down

0 comments on commit d00fbd5

Please sign in to comment.