Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lib_tool.read_to_keys #1832

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix lib_tool.read_to_keys #1832

wants to merge 1 commit into from

Conversation

IvoDD
Copy link
Collaborator

@IvoDD IvoDD commented Sep 12, 2024

Also adds a test showcasing that iterating over version, index and data key now works

Reference Issues/PRs

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@IvoDD
Fix lib_tool.read_to_keys
76b47b0 
Also adds a test showcasing that iterating over version, index and data
key now works
G-D-Petrov
G-D-Petrov reviewed Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@G-D-Petrov G-D-Petrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a file for library_tool tests:
ArcticDB/python/tests/integration/toolbox/test_library_tool.py

@IvoDD
Copy link
Collaborator Author

IvoDD commented Sep 17, 2024

This fixes one part of #1835
We still need more thorough testing for all key types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-D-Petrov G-D-Petrov G-D-Petrov left review comments

@alexowens90 alexowens90 Awaiting requested review from alexowens90 alexowens90 is a code owner

@willdealtry willdealtry Awaiting requested review from willdealtry willdealtry is a code owner

@poodlewars poodlewars Awaiting requested review from poodlewars poodlewars is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvoDD @G-D-Petrov