Skip azure compat tests #1982
Merged
Skip azure compat tests #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also since 4.5.1 is now available we replace 4.5.0 with 4.5.1 which should re-enable the lmdb and mongo tests with their segfaults fixed.
The issue with conda feedstock runners is they use some variable for abspath, which doesn't get correctly expanded by `os.path.expandvar`. This requires using `shell=True` for linux as well. This was tested to properly fix compat tests in #1931 combined with [feedstock pr](conda-forge/arcticdb-feedstock#322). However it still doesn't work for some of the macos builds which are not skipped correctly. Still this is a good change for local runs as well and we'll fix the macos issue in a separate run.
The destruction bug on mongo I thought I fixed in #1862 can still be seen. We skip the mongo test for now.
IvoDD
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
alexowens90
approved these changes
Nov 5, 2024
After we fix the segfaults we can re-enable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Skips azure compat test to make #1979 compat tests non-flaky but we still need to fix the bug from #1979.
What does this implement or fix?
I've packaged up a few other improvements in this pr as well:
shell=Trueand anabspathto successfully run on conda feedstock linux runners. This was tested to work in here, although for some reason still doesn't work on mac. We'll fix the mac issues later.Any other comments?
Checklist
Checklist for code changes...