Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1937/do not write append ref keys when staging incompletes #1985

Conversation

alexowens90
Copy link
Collaborator

Reference Issues/PRs

Fixes #1937

What does this implement or fix?

See ticket for details. Being able to create the append ref linked-list structure is useful for testing, so moved this to the LibraryTool

@alexowens90 alexowens90 changed the title Bugfix/1937/do not write append ref keys when staging incompletes WIP Bugfix/1937/do not write append ref keys when staging incompletes Nov 5, 2024
@alexowens90 alexowens90 marked this pull request as draft November 5, 2024 11:53
@alexowens90 alexowens90 changed the title WIP Bugfix/1937/do not write append ref keys when staging incompletes Bugfix/1937/do not write append ref keys when staging incompletes Nov 5, 2024
@alexowens90 alexowens90 marked this pull request as ready for review November 5, 2024 14:06
@alexowens90 alexowens90 merged commit a3b7545 into master Nov 6, 2024
126 of 127 checks passed
@alexowens90 alexowens90 deleted the bugfix/1937/do-not-write-append-ref-keys-when-staging-incompletes branch November 6, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not read/write the APPEND_REF key when calling write/append with incomplete=True on the V1 API
2 participants