Skip to content

Small cleanup arround local_object_store fixture #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Small cleanup arround local_object_store fixture #2686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b57d8a
local_object_store_cleanup
grusev Oct 2, 2025
ee505f8
not to fail on azurite
grusev Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion python/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,7 +962,12 @@ def object_version_store_prune_previous(object_store_factory) -> NativeVersionSt


@pytest.fixture(
scope="function", params=["s3_store_factory", pytest.param("azure_store_factory", marks=AZURE_TESTS_MARK)]
scope="function",
params=[
pytest.param("s3_store_factory", marks=SIM_S3_TESTS_MARK),
pytest.param("gcp_store_factory", marks=SIM_GCP_TESTS_MARK),
pytest.param("azurite_store_factory", marks=AZURE_TESTS_MARK),
],
)
def local_object_store_factory(request):
"""
Expand Down
5 changes: 4 additions & 1 deletion python/tests/unit/arcticdb/version_store/test_fork.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,10 @@ def test_parallel_reads(local_object_version_store):
symbols = ["XXX"] * 20
p = Pool(10)
local_object_version_store.write(symbols[0], df("test1"))
time.sleep(0.1) # Make sure the writes have finished, especially azurite.
if "azure" in lib.get_backing_store():
time.sleep(5) # Make sure the writes have finished, especially azurite.
else:
time.sleep(0.1)
p.map(_read_and_assert_symbol, [(local_object_version_store, s, idx) for idx, s in enumerate(symbols)])
p.close()
p.join()
Expand Down
Loading