Skip to content

Conversation

@phoebusm
Copy link
Collaborator

@phoebusm phoebusm commented Oct 7, 2025

Reference Issues/PRs

What does this implement or fix?

Use initialized numpy array for test_filter_unfilterable_data instead of unintialized one in the hope that the flakiness will be gone, as uninitialized value could result in np.nan which are considered not equal in np.allcose

In [1]: import numpy as np

In [2]: arr = np.full((3,4), np.nan)

In [3]: arr2 = np.full((3,4), np.nan)

In [4]: np.allclose(arr, arr2)
Out[4]: False

In [5]: arr = np.zeros((3,4))

In [6]: arr2 = np.zeros((3,4))

In [7]: np.allclose(arr, arr2)
Out[7]: True

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@phoebusm phoebusm added the patch Small change, should increase patch version label Oct 7, 2025
@phoebusm phoebusm merged commit 98b4884 into master Oct 10, 2025
270 of 275 checks passed
@phoebusm phoebusm deleted the fix/flaky_filter_test branch October 10, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Small change, should increase patch version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants