Fix duplicate bg

[lawrencecchen]

Summary by cubic

Fixes duplicate background behind the tab bar split buttons by replacing the red test fill with a 24px fade gradient into a solid pane background (114px total), ensuring a single, consistent backdrop.

^{Written for commit 8b23d9c. Summary will update on new commits.}

Summary by CodeRabbit

• Style
  • Enhanced the split-button overlay's visual design with an elegant themed backdrop featuring gradient effects and improved color theming. The update replaces the previous placeholder styling with proper theme-aware colors while maintaining all existing functionality, including width specifications, button rendering, opacity levels, and smooth animation controls for a more polished experience.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e54a9915-a0cc-46b9-94bb-1c15a7814cd1

📥 Commits

Reviewing files that changed from the base of the PR and between 83297bb and 8b23d9c.

📒 Files selected for processing (1)

• Sources/Bonsplit/Internal/Views/TabBarView.swift

---

📝 Walkthrough

Walkthrough

The split-button overlay background in TabBarView.swift is refined from a placeholder solid red color to a themed backdrop using a linear gradient fade with a rectangle fill, maintaining all other functionality and animation properties.

Changes

Cohort / File(s)	Summary
Split-button Overlay Background Sources/Bonsplit/Internal/Views/TabBarView.swift	Replaced solid red placeholder background with themed gradient fade (LinearGradient using TabBarColors.paneBackground) and Rectangle fill composition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• #38: Modifies the split-button overlay fade background styling in TabBarView.swift with similar visual refinements.
• #55: Updates the split-button overlay background composition in the same file, changing how the floating background is rendered.
• #58: Restructures split-button rendering and layout in TabBarView.swift, affecting the same UI overlay area.

Poem

🐰 From red to grace, a subtle shift so fine,
Gradients now dance where solids used to shine,
The overlay blooms with themed hues so bright,
A little polish makes the interface right! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch hstack-sibling-buttons

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Summary

This PR removes a leftover debug Color.red that was used to verify split-button backdrop coverage and replaces it with the correct visual implementation: a LinearGradient fade (transparent → pane background, 24 pt wide) followed by a solid Rectangle filled with the pane background color, both wrapped in an HStack constrained to the same 114 pt width. The result is a smooth, theme-aware fade behind the split buttons, matching the intended design.

• Removed temporary Color.red debug rectangle
• Added HStack(spacing: 0) with a 24 pt linear fade gradient and a solid fill rectangle, both using TabBarColors.paneBackground(for: appearance)
• The combined backdrop is correctly constrained to 114 pt, matching the previous placeholder width

Confidence Score: 5/5

• Safe to merge — removes a debug color and replaces it with the correct theme-aware gradient backdrop
• The change is a single-file, purely visual fix with no logic changes. The gradient+solid backdrop is correctly constructed and uses the existing TabBarColors.paneBackground helper, staying consistent with the rest of the file. No P1 or P0 issues found.
• No files require special attention

Important Files Changed

Filename	Overview
Sources/Bonsplit/Internal/Views/TabBarView.swift	Replaces a debug Color.red placeholder with the correct backdrop (fade gradient + solid fill) behind the split buttons overlay

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["TabBarView overlay(.trailing)"]
    B{"showSplitButtons?"}
    C["ZStack (alignment: .trailing)"]
    D["HStack(spacing: 0) — 114pt"]
    E["LinearGradient\n(transparent → bg, 24pt)"]
    F["Rectangle.fill(bg)\n(remaining 90pt)"]
    G["splitButtons\n.saturation(tabBarSaturation)"]
    H["opacity / animation based on shouldShow"]

    A --> B
    B -- Yes --> C
    C --> D
    D --> E
    D --> F
    C --> G
    C --> H

Loading

_{Reviews (1): Last reviewed commit: "Gradient fade + solid paneBackground, no..." | Re-trigger Greptile}

[cubic-dev-ai]

No issues found across 1 file