Localize tab context menu and alert strings

[lawrencecchen]

Resolves merge conflicts from #1998 by @anthhub and merges with current main.

Original PR: #1998

Localizes all tab context menu items (Close, Rename, Move to Workspace, Open in New Window) and move/rename alert strings. Adds 13 new localization keys with translations for 13+ languages.

---

Summary by cubic

Localized the tab context menu and tab rename/move dialogs by replacing hardcoded strings with String(localized:defaultValue:). Adds 13 new keys to Resources/Localizable.xcstrings with translations across all supported languages, including move-failure alerts and workspace destination options.

^{Written for commit 5663642. Summary will update on new commits.}

Summary by CodeRabbit

• New Features
  • Added support for 18 languages including Japanese, Chinese, Korean, German, Spanish, French, Italian, Arabic, Polish, Russian, and more for alert dialogs and tab management features.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cmux	Ready	Preview, Comment	Mar 31, 2026 11:18am

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8ab26415-bbd3-4a0f-a664-979b3a2eae8b

📥 Commits

Reviewing files that changed from the base of the PR and between cfac18b and 5663642.

📒 Files selected for processing (2)

• Resources/Localizable.xcstrings
• Sources/Workspace.swift

---

📝 Walkthrough

Walkthrough

This pull request adds comprehensive localization support for tab management UI alerts and related prompts across multiple languages, updating the Localizable.xcstrings file with new string keys and wiring those keys into Workspace.swift alert dialogs.

Changes

Cohort / File(s)	Summary
Localization Strings Resources/Localizable.xcstrings	Added 1,469 lines of new localized string entries for alert dialogs (alert.cancel, alert.moveTab.*, alert.renameTab.*) with translations across 18 languages including English, Japanese, Chinese (Simplified & Traditional), Korean, German, Spanish, French, Italian, and others.
Alert Dialog Localization Sources/Workspace.swift	Updated tab rename and move alert dialogs to use localized string keys with fallback defaults instead of hardcoded English text; wired new localization keys to UI button labels and alert messages without altering control flow logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• feat: add Japanese localization with String Catalog #819: Modifies the same Workspace.swift alert localization usage and Localizable.xcstrings entries for tab management dialogs.
• Add 16 new languages to localization #895: Expands localization resources in Localizable.xcstrings with new keys and aligns UI strings to localized keys across the application.
• Summarize multi-workspace close confirmation #1329: Updates the same localization keys (alert.renameTab, alert.moveTab) in Resources/Localizable.xcstrings and integrates them into workspace UI alerts.

Poem

🐰 Strings now flutter in many tongues,
From English to Thai, the work is done,
Alerts dressed in silk of sixteen lands,
A world of words now in our hands! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/localize-tab-context-menu-resolved

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 2 files

[greptile-apps]

Greptile Summary

This PR resolves merge conflicts from #1998 and lands the alert-dialog localization for tab rename and tab move operations in Workspace.swift. Thirteen hard-coded English strings are replaced with String(localized:defaultValue:) calls, and 13 corresponding keys (with translations for 18 locales) are added to Localizable.xcstrings.

Key changes:

• promptRenamePanel: title, message, placeholder, Rename button, and Cancel button are now localized.
• promptMovePanel: title, message, destination option strings, Move button, and Cancel button are now localized; the failure alert is also localized.
• Two shared utility keys (alert.cancel, alert.ok) are introduced for button labels reused across dialogs.
• All 13 call-site keys have exact matches in Localizable.xcstrings and default values that match the English translations — no missing or mismatched keys.
• One P2 style note: the new keys use an alert.* prefix while the adjacent confirmClosePanel dialog already uses a dialog.* prefix (e.g. dialog.closeTab.cancel), creating a mild namespace inconsistency worth harmonizing in a follow-up.

Confidence Score: 5/5

Safe to merge — all 13 localization keys are correctly wired between Workspace.swift and Localizable.xcstrings, no logic changes, no missing or mismatched keys.

All call-site keys have exact matches in xcstrings with correct default values. No logic is changed; only string literals are replaced with localized lookups. The single finding is a P2 naming-convention inconsistency (alert.* vs the pre-existing dialog.* prefix) that has no runtime impact.

No files require special attention.

Important Files Changed

Filename	Overview
Sources/Workspace.swift	Replaces 13 hard-coded English alert-dialog strings (rename tab, move tab, move failed) with String(localized:defaultValue:) calls matching the newly added xcstrings keys; logic is unchanged.
Resources/Localizable.xcstrings	Adds 13 new localization keys (alert.cancel, alert.ok, alert.moveTab., alert.renameTab.) with translations for 18 locales; all keys match the call sites in Workspace.swift.

Sequence Diagram

sequenceDiagram
    participant User
    participant ContextMenu as Tab Context Menu
    participant Workspace as Workspace.swift
    participant Localizable as Localizable.xcstrings

    User->>ContextMenu: Right-click tab → Rename
    ContextMenu->>Workspace: promptRenamePanel(tabId:)
    Workspace->>Localizable: String(localized: "alert.renameTab.title")
    Workspace->>Localizable: String(localized: "alert.renameTab.message")
    Workspace->>Localizable: String(localized: "alert.renameTab.placeholder")
    Workspace->>Localizable: String(localized: "alert.renameTab.rename")
    Workspace->>Localizable: String(localized: "alert.cancel")
    Workspace-->>User: NSAlert (localized)

    User->>ContextMenu: Right-click tab → Move to Workspace
    ContextMenu->>Workspace: promptMovePanel(tabId:)
    Workspace->>Localizable: String(localized: "alert.moveTab.title")
    Workspace->>Localizable: String(localized: "alert.moveTab.message")
    Workspace->>Localizable: String(localized: "alert.moveTab.newWorkspaceInCurrentWindow")
    Workspace->>Localizable: String(localized: "alert.moveTab.selectedWorkspaceInNewWindow")
    Workspace->>Localizable: String(localized: "alert.moveTab.move")
    Workspace->>Localizable: String(localized: "alert.cancel")
    Workspace-->>User: NSAlert with NSPopUpButton (localized)
    User->>Workspace: Confirm Move
    alt Move fails
        Workspace->>Localizable: String(localized: "alert.moveTab.failed.title")
        Workspace->>Localizable: String(localized: "alert.moveTab.failed.message")
        Workspace->>Localizable: String(localized: "alert.ok")
        Workspace-->>User: Failure NSAlert (localized)
    end

Loading

_{Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile}

[greptile-apps]

Inconsistent key prefix convention (alert.* vs dialog.*)

The adjacent confirmClosePanel dialog already uses the dialog.closeTab.* prefix (e.g. dialog.closeTab.cancel, dialog.closeTab.close). This PR introduces a parallel alert.* namespace for the rename/move dialogs. The two families now coexist and both translate "Cancel" (alert.cancel vs dialog.closeTab.cancel), which makes it harder for translators to know which key to update when UI copy changes.

Consider using the dialog.* prefix here as well (e.g. dialog.renameTab.*, dialog.moveTab.*) to keep the namespace consistent, or document the intended distinction between alert.* and dialog.* in a comment.

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}