Skip to content

fix: update surface config on theme switch to restore ANSI palette #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shelldonGuo wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix: update surface config on theme switch to restore ANSI palette #2685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/ContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2005,7 +2005,7 @@ struct ContentView: View {
}

static func tmuxWorkspacePaneExactRect(
for panel: Panel,
for panel: any Panel,
in contentView: NSView
) -> CGRect? {
let targetView: NSView?
Expand Down
8 changes: 8 additions & 0 deletions Sources/GhosttyTerminalView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5647,6 +5647,14 @@ class GhosttyNSView: NSView, NSUserInterfaceValidations {
}
return
}
// Push the current config to this surface before switching the color scheme.
// ghostty_surface_set_color_scheme alone only updates the scheme flag but does
// not re-apply the ANSI palette (OSC 4, colors 0-15) to the existing surface.
// Calling ghostty_surface_update_config first ensures the surface picks up the
// full palette for the new scheme (light/dark) from the current config.
if let config = GhosttyApp.shared.config {
ghostty_surface_update_config(surface, config)
}
ghostty_surface_set_color_scheme(surface, scheme)
appliedColorScheme = scheme
if GhosttyApp.shared.backgroundLogEnabled {
Expand Down