Move iOS app into repo with public-only Convex sync and proprietary licensing#367
Open
lawrencecchen wants to merge 235 commits intomainfrom
Open
Move iOS app into repo with public-only Convex sync and proprietary licensing#367lawrencecchen wants to merge 235 commits intomainfrom
lawrencecchen wants to merge 235 commits intomainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/fun/cmux/ios-appinto this repo asios/without moving the existing macOS app layout.~/fun/cmuxwhile importing only public config:ios/scripts/sync-public-convex-vars.sh(whitelisted public env keys only)ios/scripts/sync-convex-types.sh(regenerateConvexApiTypes.swiftfrom~/fun/cmux/packages/convex)ios/Sources/Config/LocalConfig.plistgitignored and updateEnvironment.swift+LocalConfig.example.plistfor explicit dev/prod public overrides.ios/**is proprietary (ios/LICENSE) and document the repo-wide scope inLICENSE_SCOPE.md.Testing
cd ios && ./scripts/sync-public-convex-vars.sh --source-root /Users/lawrencechen/fun/cmux(pass)cd ios && ./scripts/sync-convex-types.sh --source-root /Users/lawrencechen/fun/cmux(pass)cd ios && xcodegen generate(pass)cd ios && xcodebuild -project cmux.xcodeproj -list(pass)cd . && bash -n ios/scripts/sync-public-convex-vars.sh ios/scripts/sync-convex-types.sh ios/scripts/reload.sh ios/scripts/device.sh ios/scripts/testflight.sh(pass)Issues
~/fun/cmux, and ensure no non-public secrets are committed.