-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Honor Ghostty background-opacity across all cmux chrome #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ struct GhosttyConfig { | |
|
|
||
| // Colors (from theme or config) | ||
| var backgroundColor: NSColor = NSColor(hex: "#272822")! | ||
| var backgroundOpacity: Double = 1.0 | ||
| var foregroundColor: NSColor = NSColor(hex: "#fdfff1")! | ||
| var cursorColor: NSColor = NSColor(hex: "#c0c1b5")! | ||
| var cursorTextColor: NSColor = NSColor(hex: "#8d8e82")! | ||
|
|
@@ -148,6 +149,10 @@ struct GhosttyConfig { | |
| if let color = NSColor(hex: value) { | ||
| backgroundColor = color | ||
| } | ||
| case "background-opacity": | ||
| if let opacity = Double(value) { | ||
| backgroundOpacity = opacity | ||
| } | ||
|
Comment on lines
+152
to
+155
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Validate and clamp parsed Line 153 currently accepts any 🔧 Proposed fix case "background-opacity":
- if let opacity = Double(value) {
- backgroundOpacity = opacity
+ if let opacity = Double(value), opacity.isFinite {
+ backgroundOpacity = min(1.0, max(0.0, opacity))
}🤖 Prompt for AI Agents |
||
| case "foreground": | ||
| if let color = NSColor(hex: value) { | ||
| foregroundColor = color | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fallback path does not actually run on subsequent theme/opacity updates, so browser-focused workspaces can keep a stale NSWindow background after
background-opacitychanges.refreshGhosttyAppearanceConfigalready skipsterminalPanel.applyWindowBackgroundIfActive()when no terminal is focused, and this code relies onWindowAccessorto handle that case, butWindowAccessordefaults todedupeByWindow = trueand short-circuits callbacks unless the window instance changes (Sources/WindowAccessor.swift, guard onlastWindow !== window), so the newly added browser fallback is effectively one-shot.Useful? React with 👍 / 👎.