Skip to content

Conversation

@KSemenenko
Copy link
Member

Summary

  • ensure the model integration test asserts native assets are present instead of skipping
  • remove the SkipException dependency so missing assets surface as test failures

Testing

  • dotnet build

https://chatgpt.com/codex/tasks/task_e_68fc8959815c8326976b375ed6a4a2be

Copilot AI review requested due to automatic review settings October 25, 2025 09:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR converts the model integration test from a skip-on-missing-assets approach to a fail-on-missing-assets approach. The test now asserts that required native assets (model path and library) are properly configured rather than silently skipping when they're absent.

  • Replaces Skip.If() calls with Assert.False() and Assert.True() statements
  • Renames EnsureAssetsOrSkip() to EnsureAssets() to reflect the new behavior
  • Adds detailed error messages explaining which environment variables need to be set

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@KSemenenko KSemenenko merged commit 0503a45 into main Oct 25, 2025
3 of 4 checks passed
@KSemenenko KSemenenko deleted the codex/fix-skip-not-found-errors-in-tests branch October 25, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants