Improve Screenshot Detection by Modifying capture-screenshot.yml #1007
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ rule: | |
| - [email protected] | ||
| - "@_re_fox" | ||
| - [email protected] | ||
| - "Abhyuday K Hegde" | ||
| scopes: | ||
| static: function | ||
| dynamic: span of calls | ||
|
|
@@ -17,15 +18,18 @@ rule: | |
| - BFB9B5391A13D0AFD787E87AB90F14F5:0x1314610A | ||
| - 7204e3efc2434012e13ca939db0d0b02:0x414070 | ||
| - 50D5EE1CE2CA5E30C6B1019EE64EEEC2:0x406E07 | ||
| - 0a30182ff3a6b67beb0f2cda9d0de678:0x407910 | ||
| features: | ||
| - or: | ||
| # Classic GDI Capture | ||
| - and: | ||
| - or: | ||
| - api: user32.GetWindowDC | ||
| - api: user32.GetDC | ||
| - and: | ||
| - api: gdi32.CreateDC | ||
| - optional: | ||
| - string: "DISPLAY" | ||
| - or: | ||
| - api: gdi32.BitBlt | ||
| - api: gdi32.GetDIBits | ||
|
|
@@ -43,3 +47,31 @@ rule: | |
| - and: | ||
| - api: BitBlt | ||
| - api: System.Drawing.Graphics::CopyFromScreen | ||
| - and: | ||
| - api: "SelectObject" | ||
| - or: | ||
| - api: "BitBlt" | ||
| - api: "StretchBlt" | ||
| - api: "PrintWindow" | ||
| # GDI+ Graphics API chain | ||
| - and: | ||
| - api: "GdipCreateBitmapFromScan0" | ||
| - api: "GdipGetImageGraphicsContext" | ||
| - api: "GdipGetDC" | ||
| # Direct GDI+ screen copy | ||
| - and: | ||
| - api: "Gdiplus::Graphics::FromHDC" | ||
| - api: "Gdiplus::Graphics::CopyFromScreen" | ||
|
Comment on lines
+63
to
+64
There was a problem hiding this comment. Should these be api or function-name features? There was a problem hiding this comment. Hello @mike-hunhoff ! |
||
| # DirectX method of screen capture | ||
| - and: | ||
| - or: | ||
| - api: "PrintWindow" | ||
| - api: "StretchBlt" | ||
| - and: | ||
| - api: "DwmGetDxSharedSurface" | ||
| - optional: | ||
| - string: "DXGI" | ||
| - or: | ||
| - api: "Direct3DCreate9" | ||
| - api: "IDirect3DDevice9::GetFrontBufferData" | ||
|
Comment on lines
+75
to
+76
There was a problem hiding this comment. Should these be api or function-name features? There was a problem hiding this comment. Over here too, Direct3DCreate 9 is a direct import of a dll file right? There was a problem hiding this comment. Furthermore, changing these features to function-name would require me to change the static scope of the rule to file. Would it not increase the number of false positives? |
||
| - string: "IDirect3DSurface9::GetDC" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api features do not require ". Please remove the " from this api feature and all that follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I'll remove the quotes!